Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LastLogin to the User API #7196

Conversation

zeripath
Copy link
Contributor

This PR adds the LastLogin to the API returns for /api/v1/user /api/v1/users/:username and /api/v1/admin/users

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label Jun 13, 2019
@zeripath zeripath changed the title Add lastlogin to the api Add LastLogin to the User api Jun 13, 2019
@zeripath zeripath changed the title Add LastLogin to the User api Add LastLogin to the User API Jun 13, 2019
@codecov-io
Copy link

codecov-io commented Jun 13, 2019

Codecov Report

Merging #7196 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7196      +/-   ##
==========================================
- Coverage   41.52%   41.52%   -0.01%     
==========================================
  Files         449      449              
  Lines       61310    61314       +4     
==========================================
  Hits        25461    25461              
- Misses      32497    32501       +4     
  Partials     3352     3352
Impacted Files Coverage Δ
modules/structs/user.go 100% <ø> (ø) ⬆️
models/user.go 50.41% <100%> (+0.09%) ⬆️
routers/api/v1/convert/convert.go 83.96% <100%> (+0.15%) ⬆️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 273f199...4410c74. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 13, 2019
@lunny
Copy link
Member

lunny commented Jun 14, 2019

will fix #7197

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 15, 2019
@sapk
Copy link
Member

sapk commented Jun 15, 2019

It maybe good to add at least small test to:

func TestUser_APIFormat(t *testing.T) {

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 16, 2019
@techknowlogick techknowlogick merged commit cf2221e into go-gitea:master Jun 16, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 17, 2019
@zeripath zeripath deleted the add-last-login-timestamp-to-user-apiformat branch June 24, 2019 18:04
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants