Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix missing repo description when migrating #7000

Merged
merged 1 commit into from
May 20, 2019
Merged

Fix missing repo description when migrating #7000

merged 1 commit into from
May 20, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 20, 2019

Should fix #6997

@lunny lunny added the type/bug label May 20, 2019
@lunny lunny added this to the 1.9.0 milestone May 20, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 20, 2019
@codecov-io
Copy link

Codecov Report

Merging #7000 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7000      +/-   ##
==========================================
- Coverage   41.44%   41.44%   -0.01%     
==========================================
  Files         441      441              
  Lines       59696    59699       +3     
==========================================
+ Hits        24739    24740       +1     
- Misses      31732    31733       +1     
- Partials     3225     3226       +1
Impacted Files Coverage Δ
modules/migrations/migrate.go 23.35% <0%> (-0.53%) ⬇️
models/repo_list.go 72.08% <0%> (-1.02%) ⬇️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8de76b6...a87628e. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 20, 2019
@lafriks lafriks merged commit 02542a2 into go-gitea:master May 20, 2019
@lunny lunny deleted the lunny/fix_migrate_missing_description branch May 20, 2019 14:48
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
fix missing repo description when migrating (go-gitea#7000)
1f9df4c
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

No description set when migrating the repository
5 participants
@lunny @codecov-io @lafriks @adelowo @GiteaBot