Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotate serv.log, http.log and hook logs and stop stacktracing in these #6935

Merged
merged 2 commits into from
May 14, 2019

Conversation

zeripath
Copy link
Contributor

Fixes #6934 by auto-rotating serv.log et al.

Also fixes issue whereby stack-traces are being produced in these logs.

@zeripath zeripath added this to the 1.9.0 milestone May 13, 2019
@zeripath zeripath changed the title Rotate unusual logs and stop stacktracing Rotate serv.log, http.log and hook logs and stop stacktracing in these May 13, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 13, 2019
@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #6935 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6935   +/-   ##
======================================
  Coverage    41.4%   41.4%           
======================================
  Files         441     441           
  Lines       59736   59736           
======================================
  Hits        24734   24734           
  Misses      31762   31762           
  Partials     3240    3240
Impacted Files Coverage Δ
modules/log/log.go 71.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e63274e...9ef4bb9. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2019
@lafriks lafriks merged commit c0fc6cd into go-gitea:master May 14, 2019
@zeripath zeripath deleted the rotate-serv-logs branch May 20, 2019 15:36
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

serv.log not getting rolled over
6 participants