Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README WordPress the code is overflowing #6679 #6696

Merged
merged 7 commits into from
Apr 28, 2019

Conversation

ZerooCool
Copy link
Contributor

@ZerooCool ZerooCool commented Apr 21, 2019

README WordPress the code is overflowing. Fixes #6679

@lunny
Copy link
Member

lunny commented Apr 21, 2019

CI failed

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 21, 2019
@codecov-io
Copy link

codecov-io commented Apr 23, 2019

Codecov Report

Merging #6696 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6696      +/-   ##
==========================================
- Coverage   41.22%   41.22%   -0.01%     
==========================================
  Files         421      421              
  Lines       58054    58054              
==========================================
- Hits        23935    23933       -2     
- Misses      30952    30955       +3     
+ Partials     3167     3166       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e31112...8259882. Read the comment docs.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 23, 2019
@ZerooCool
Copy link
Contributor Author

In this file :
public/less/_repository.less
Line 330
Add this code for resolve this issue :

        pre {
            overflow: scroll;
        }

I can not see the diff for the changes that have been made.

Note that in my opinion, you only need to add the following code:

If it's OK to display the WordPress README ...
If it's OK to display files (PHP for example) and the lines are always correctly numbered, then for me this problem is solved.

#6679

@lafriks lafriks added this to the 1.9.0 milestone Apr 24, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 26, 2019
@techknowlogick techknowlogick merged commit 345bc06 into go-gitea:master Apr 28, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README WordPress the code is overflowing
8 participants