Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bash requirement in makefile #6617

Merged
merged 1 commit into from
Apr 14, 2019
Merged

remove bash requirement in makefile #6617

merged 1 commit into from
Apr 14, 2019

Conversation

techknowlogick
Copy link
Member

as title

@techknowlogick techknowlogick added type/bug topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile labels Apr 14, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 14, 2019
@codecov-io
Copy link

Codecov Report

Merging #6617 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6617      +/-   ##
==========================================
- Coverage   40.48%   40.46%   -0.03%     
==========================================
  Files         406      406              
  Lines       54484    54484              
==========================================
- Hits        22057    22045      -12     
- Misses      29390    29402      +12     
  Partials     3037     3037
Impacted Files Coverage Δ
models/unit.go 0% <0%> (-14.29%) ⬇️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de6527b...2cea81e. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 14, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 14, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 14, 2019
@techknowlogick techknowlogick merged commit 77ffb15 into go-gitea:master Apr 14, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch April 14, 2019 20:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants