Use stricter boundaries for auto-link detection #6522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently autolinks use \W for boundary detection which creates many situations of inserting links into places they don't belong (paths, URLs, UUIDs, etc...) This fixes that by replacing \W and only allowing these matches to touch an open paren or bracket (matching what seems to be Github behavior) in addition to whitespace and start of line. Similar for ending boundary as well. Fixes go-gitea#6149 (and probably others)
Replace incorrect test with a value that is a valid username, based on:
"Username should contain only alphanumeric, dash ('-'), underscore ('_')
and dot ('.') characters."
Codecov Report
@@ Coverage Diff @@
## master #6522 +/- ##
==========================================
+ Coverage 40.4% 40.41% +0.01%
==========================================
Files 404 404
Lines 54089 54089
==========================================
+ Hits 21852 21860 +8
+ Misses 29224 29215 -9
- Partials 3013 3014 +1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Apr 5, 2019
GiteaBot
added
lgtm/need 1
Matching Github behavior
Create a specific capture group for email address and then use FindStringSubmatchIndex to allow for non-matching patterns as boundaries.
zeripath
approved these changes
Apr 6, 2019
GiteaBot
added
lgtm/done
|
@zeripath sure, added some more test cases here |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently autolinks use \W for boundary detection which creates many
situations of inserting links into places they don't belong (paths,
URLs, UUIDs, etc...)
This fixes that by replacing \W and only allowing these matches to touch
an open paren or bracket (matching what seems to be Github behavior) in
addition to whitespace and start of line. Similar for ending boundary as
well (also allowing for a literal period).
Fixes #6149
(and probably others)
Before:
After:
