Fix Hook & HookList in Swagger #6432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Segev Finer <segev@codeocean.com>
segevfiner
force-pushed
the
swagger-hook-fix
branch
from
b44dd6b
to
61f43ba
Compare
Codecov Report
@@ Coverage Diff @@
## master #6432 +/- ##
==========================================
- Coverage 38.86% 38.86% -0.01%
==========================================
Files 365 365
Lines 51413 51413
==========================================
- Hits 19984 19980 -4
- Misses 28559 28564 +5
+ Partials 2870 2869 -1
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
lafriks
approved these changes
Mar 26, 2019
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Mar 26, 2019
GiteaBot
added
lgtm/done
|
Please send backport to release/v1.8 branch |
@lafriks You want me to send a backport PR? Or did you mean someone else? |
|
Yes if you could send the backport that's best. Easiest thing to do is to cherry pick commit b4941f7 on to release/v1.8 and send a PR from that. |
segevfiner
pushed a commit
to codeocean/gitea
that referenced
this pull request
Mar 26, 2019
Signed-off-by: Segev Finer <segev@codeocean.com>
lafriks
pushed a commit
that referenced
this pull request
Mar 27, 2019
techknowlogick
added
the
backport/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
Hook&HookListin Swagger which seemed to accidentally point to an array/slice ofBranch.