Reapply gogs hmac patch #6430
Closed
Reapply gogs hmac patch #6430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not send "secret" field in webhook json but rather a header with HMAC. Sending X-Gogs-Signature header and X-Hub-Signature with sha265= prefix.
zobo
changed the title
zobo
force-pushed
the
feature/issue-3901-use-hmac-for-signing-webhooks
branch
from
a0e624d
to
15db889
Compare
lafriks
added
pr/breaking
|
Please send PR to SDK first |
GiteaBot
added
the
lgtm/need 2
Thanks, will do. |
techknowlogick
requested changes
Mar 26, 2019
| @@ -731,6 +730,8 @@ func (t *HookTask) deliver() { | |||
| Header("X-Gitea-Event", string(t.EventType)). | |||
| Header("X-Gitea-Signature", t.Signature). | |||
| Header("X-Gogs-Delivery", t.UUID). | |||
| Header("X-Gogs-Signature", t.Signature). | |||
There was a problem hiding this comment.
Gogs signature is already set two lines down
techknowlogick
requested changes
Mar 26, 2019
Agreed, will work on that too. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions. |
|
This pull request has been automatically closed because of inactivity. You can re-open it if needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not send "secret" field in webhook json but rather a header with HMAC.
Sending X-Gogs-Signature header and X-Hub-Signature with sha265= prefix.
gogs/gogs@3609efe
#3901