Add signatures to webhooks #6428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
added
the
type/enhancement
techknowlogick
commented
Mar 25, 2019
| @@ -657,11 +662,23 @@ func prepareWebhook(e Engine, w *Webhook, repo *Repository, event HookEventType, | |||
| payloader = p | |||
| } | |||
|
|
|||
| var signature string | |||
There was a problem hiding this comment.
Note: On L611 the secret is still added to the payload. This is being kept that was as to not be a breaking change.
GiteaBot
added
the
lgtm/need 2
Codecov Report
@@ Coverage Diff @@
## master #6428 +/- ##
==========================================
- Coverage 38.85% 38.85% -0.01%
==========================================
Files 365 365
Lines 51401 51413 +12
==========================================
+ Hits 19974 19978 +4
- Misses 28559 28566 +7
- Partials 2868 2869 +1
Continue to review full report at Codecov.
|
lafriks
approved these changes
Mar 25, 2019
GiteaBot
added
lgtm/need 1
adelowo
approved these changes
Mar 25, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3901
Code is based on PR from Gogs (PR 3692)