Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable benchmarking during tag events on DroneIO #6365

Merged
merged 1 commit into from
Mar 19, 2019
Merged

Disable benchmarking during tag events on DroneIO #6365

merged 1 commit into from
Mar 19, 2019

Conversation

techknowlogick
Copy link
Member

As title, will need to be backported to release/v1.8

(When this gets backported 1.8.0-rc1 can be retagged)

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 19, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 19, 2019
@codecov-io
Copy link

Codecov Report

Merging #6365 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6365      +/-   ##
==========================================
+ Coverage   38.86%   38.87%   +0.01%     
==========================================
  Files         365      365              
  Lines       51341    51341              
==========================================
+ Hits        19953    19960       +7     
+ Misses      28516    28510       -6     
+ Partials     2872     2871       -1
Impacted Files Coverage Δ
routers/repo/view.go 42.07% <0%> (+0.99%) ⬆️
modules/process/manager.go 81.15% <0%> (+4.34%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b34996a...946cc2a. Read the comment docs.

@techknowlogick techknowlogick merged commit 99d919e into go-gitea:master Mar 19, 2019
@techknowlogick techknowlogick deleted the techknowlogick-patch-3 branch March 19, 2019 06:24
@sapk
Copy link
Member

sapk commented Mar 27, 2019

@techknowlogick why ? does it failed during CI ? Because the goal was mainly to keep track of performance between releases.

@techknowlogick
Copy link
Member Author

@sapk yes, it fails on the migrate benchmark. I think we should wait until we migrate to Drone 1.0.0 to resolve this so we can have a separate benchmark pipeline and have that run on a dedicated machine as well.

@lunny
Copy link
Member

lunny commented Mar 28, 2019

Create an issue for that is better so that we will not forget that.

@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants