Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose issue stopwatch toggling via API #5970

Merged
merged 8 commits into from
Feb 7, 2019

Conversation

adelowo
Copy link
Member

@adelowo adelowo commented Feb 5, 2019

.. #4327 automatically stops the stopwatch but this PR will be useful in case there
is a need to programmatically toggle the stopwatch.

Fixes #5942

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 5, 2019
@adelowo adelowo changed the title Expose issue stopwatch in API Expose issue stopwatch toggling via API Feb 5, 2019
@codecov-io
Copy link

codecov-io commented Feb 5, 2019

Codecov Report

Merging #5970 into master will decrease coverage by 0.09%.
The diff coverage is 3.27%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #5970     +/-   ##
=========================================
- Coverage    38.8%   38.71%   -0.1%     
=========================================
  Files         330      330             
  Lines       48731    48853    +122     
=========================================
+ Hits        18911    18912      +1     
- Misses      27081    27201    +120     
- Partials     2739     2740      +1
Impacted Files Coverage Δ
routers/api/v1/repo/issue.go 23.46% <0%> (-7.81%) ⬇️
routers/api/v1/api.go 73.74% <100%> (+0.2%) ⬆️
modules/process/manager.go 76.81% <0%> (-4.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc48c12...f10ff72. Read the comment docs.

@techknowlogick techknowlogick added the modifies/api This PR adds API routes or modifies them label Feb 5, 2019
@techknowlogick techknowlogick added this to the 1.8.0 milestone Feb 5, 2019
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't actually like toggle method as you are kind of guessing state... I would prefer if API had start & stop methods

@adelowo
Copy link
Member Author

adelowo commented Feb 5, 2019

Done @lafriks.

routers/api/v1/repo/issue.go Outdated Show resolved Hide resolved
routers/api/v1/repo/issue.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 6, 2019
@lafriks lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 6, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 7, 2019
@techknowlogick techknowlogick merged commit 9dfdf80 into go-gitea:master Feb 7, 2019
@adelowo adelowo deleted the expose_time_tracking_as_api branch February 7, 2019 08:09
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Expose Time Tracker Start and Stop in API
5 participants