-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
word-break the WebHook url to prevent a ui-break #5432
word-break the WebHook url to prevent a ui-break #5432
Conversation
right now, the url is displayed with an anchor tag with no classes. If the url is really really long, the url will break out of the containing div and (depending on the url length) the browser shows the horizontal scrollbar. This pr makes use of the already existing css class `dont-break-out` which gives all the anchor the necessary properties to prevent the break. Another solution could be to introduce some classes like `text text-break-word`, but that would duplicate the `dont-break-out` class just for text elements that use the `text` class. fixes: go-gitea#5416 Signed-off-by: Roman <romaaan.git@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #5432 +/- ##
=========================================
Coverage ? 37.56%
=========================================
Files ? 317
Lines ? 46821
Branches ? 0
=========================================
Hits ? 17590
Misses ? 26732
Partials ? 2499 Continue to review full report at Codecov.
|
You seem to be missing the definition for “dont-break-out" ? Or is it an already defined class ? Sorry I’m on mobile and cannot check or test the PR. |
@adelowo it is already defined in gitea css |
Backport PR #5445 |
right now, the url is displayed with an anchor tag with no classes. If the url is really really long, the url will break out of the containing div and (depending on the url length) the browser shows the horizontal scrollbar.
This pr makes use of the already existing css class
dont-break-out
which gives all the anchor the necessary properties to prevent the break.Another solution could be to introduce some classes like
text text-break-word
, but that would duplicate thedont-break-out
class just for text elements that use thetext
class.fixes: #5416
Before:
After: