Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set ACL on releases #5344

Merged
merged 3 commits into from
Nov 16, 2018
Merged

Set ACL on releases #5344

merged 3 commits into from
Nov 16, 2018

Conversation

techknowlogick
Copy link
Member

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 16, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 16, 2018
@lafriks
Copy link
Member

lafriks commented Nov 16, 2018 •
edited
Loading

We would need to set this for existing files manually, right?

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@e033d21). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5344   +/-   ##
=========================================
  Coverage          ?   37.36%           
=========================================
  Files             ?      312           
  Lines             ?    46409           
  Branches          ?        0           
=========================================
  Hits              ?    17339           
  Misses            ?    26586           
  Partials          ?     2484

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e033d21...d0f2d18. Read the comment docs.

@techknowlogick
Copy link
Member Author

@lafriks yes that is correct.

@techknowlogick techknowlogick merged commit 241ee79 into go-gitea:master Nov 16, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-9 branch November 16, 2018 16:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jonasfranz jonasfranz jonasfranz approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/deployment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@techknowlogick @lafriks @codecov-io @jonasfranz @adelowo @bkcsoft