Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added webkit-font-smoothing #489

Closed
wants to merge 1 commit into from
Closed

Added webkit-font-smoothing #489

wants to merge 1 commit into from

Conversation

deanpcmad
Copy link

Hey there, Here I'm adding -webkit-font-smoothing to the body CSS tag to make fonts look nicer on Mac.

Before:
screen shot 2016-12-26 at 22 11 08

After
screen shot 2016-12-26 at 22 11 21

andreynering
andreynering reviewed Dec 27, 2016
View reviewed changes
public/css/index.css
@@ -8,6 +8,7 @@ body {
font-family: "Helvetica Neue", "Microsoft YaHei", Arial, Helvetica, sans-serif !important;
background-color: #fff;
overflow-y: scroll;
-webkit-font-smoothing: antialiased;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated by less. This should be added to less files.

@andreynering andreynering added the topic/ui Change the appearance of the Gitea UI label Dec 27, 2016
@andreynering andreynering added this to the 1.1.0 milestone Dec 27, 2016
@denji
Copy link
Contributor

denji commented Dec 29, 2016

Semantic-Org/Semantic-UI#3576

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2016
@tboerger
Copy link
Member

Still needs to be changed on less files until we get a fix on semantic ui.

@deanpcmad
Copy link
Author

Sure, shall I revert that commit and make a change to the .less file or shall I create a new PR?

@Bwko
Copy link
Member

Bwko commented Dec 31, 2016 •
edited
Loading

@deanpcmad Just update this PR 😄

@denji
Copy link
Contributor

denji commented Dec 31, 2016 •
edited
Loading

@deanpcmad I suggest you create a file to override the additional prefixes .less or use autoprefixer with the downgrade of the supported browsers. Prefixes are automatically added/cleanup in the case of using autoprefix (browserslist queries).

@Bwko
Copy link
Member

Bwko commented Jan 11, 2017

@deanpcmad Any updates on this?

@Bwko Bwko mentioned this pull request Jan 25, 2017
Merged
@andreynering
Copy link
Contributor

Closed as #763

@tboerger tboerger removed this from the 1.1.0 milestone Feb 26, 2017
@tboerger tboerger added issue/duplicate The issue has already been reported. and removed topic/ui Change the appearance of the Gitea UI lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 26, 2017
@mrsdizzie mrsdizzie mentioned this pull request Jun 17, 2020
Closed
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andreynering andreynering andreynering left review comments

Assignees
No one assigned
Labels
issue/duplicate The issue has already been reported.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@deanpcmad @denji @tboerger @Bwko @andreynering