Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add whitespace handling to PR-comparsion #4683

Merged
merged 5 commits into from
Aug 14, 2018

Commits on Aug 13, 2018

  1. Add whitespace handling to PR-comparsion

    In a PR we have to keep an eye on a lot of different things. But sometimes the
    bare code is the key-thing we want to care about and just don't want to care
    about fixed indention on some places. Especially if we follow the pathfinder
    rule we face a lot of these situations because these changes don't break the
    code in many languages but improve the readability a lot.
    
    So this change introduce a fine graned button to adjust the way how the
    reviewer want to see whitespace-changes within the code.
    
    The possibilities reflect the possibilities from git itself except of the
    `--ignore-blank-lines` flag because that one is also handled by `-b` and is
    really rare.
    
    Signed-off-by: Felix Nehrke <felix@nehrke.info>
    nemoinho authored and Felix Nehrke committed Aug 13, 2018
    Configuration menu
    Copy the full SHA
    68df14b View commit details
    Browse the repository at this point in the history
  2. Remove de-DE translation

    lafriks authored Aug 13, 2018
    Configuration menu
    Copy the full SHA
    be4c6c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b4c5d85 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d8f7767 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2018

  1. Configuration menu
    Copy the full SHA
    3127f2e View commit details
    Browse the repository at this point in the history