-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webhook type conflation. #4285
Conversation
aunger
commented
Jun 20, 2018
- Fix typo that caused Gogs hooks to be created as Gitea hooks.
- Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one).
- Fix typo that caused Gogs hooks to be created as Gitea hooks. - Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one). Signed-off-by: Russell Aunger <rba@live.com>
I think the drone test failed during Docker setup, unrelated to this change. Can someone rerun it? |
Done |
Codecov Report
@@ Coverage Diff @@
## master #4285 +/- ##
==========================================
+ Coverage 20% 20.01% +<.01%
==========================================
Files 153 153
Lines 30584 30584
==========================================
+ Hits 6119 6122 +3
+ Misses 23537 23535 -2
+ Partials 928 927 -1
Continue to review full report at Codecov.
|
LGTM |
@aunger Please create a backport PR (cherry-pick commit from master) to |
@aunger please send a backport to release/v1.4 |
- Fix typo that caused Gogs hooks to be created as Gitea hooks. - Fix typo that caused Gogs hooks to be duplicated upon edit (though this bug was masked by the previous one). Signed-off-by: Russell Aunger <rba@live.com>