HTML-escape plain-text READMEs in previews #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4192 +/- ##
==========================================
+ Coverage 19.96% 19.97% +<.01%
==========================================
Files 153 153
Lines 30494 30498 +4
==========================================
+ Hits 6088 6091 +3
- Misses 23491 23493 +2
+ Partials 915 914 -1
Continue to review full report at Codecov.
|
bkcsoft
added
the
lgtm/need 2
lunny
added
type/bug
topic/security
techknowlogick
approved these changes
Jun 9, 2018
bkcsoft
added
lgtm/need 1
daviian
suggested changes
Jun 9, 2018
daviian
approved these changes
Jun 9, 2018
bkcsoft
added
lgtm/done
lafriks
approved these changes
Jun 9, 2018
|
@nickolas360 can you please backport this (by cherry-pick 2bb73fe) to release/v1.4? |
|
BTW, it's related to #3903 but fix only a part of it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previews of plain-text README files are not currently HTML-escaped; this causes issues when READMEs contain characters like
<and>, including constructs likeCopyright 2018 Example <me@example.com>, which currently renders asCopyright 2018 Example.This PR ensures that plain-text READMEs are HTML-escaped.