Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Contribution docs with non-404 link #4077

Merged
merged 3 commits into from
May 30, 2018
Merged

Update Contribution docs with non-404 link #4077

merged 3 commits into from
May 30, 2018

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented May 29, 2018 •
edited
Loading

Kubernetes changed their documentation again. This commit targets a specific blob so that the link does not 404

@techknowlogick
Link to specific blob of docs
e441278 
k8s changed their documentation again. This commit targets a specific blob so that the link does not 404
@techknowlogick techknowlogick added the type/docs This PR mainly updates/creates documentation label May 29, 2018
@techknowlogick techknowlogick changed the title Link to specific blob of docs Update Contribution docs with non-404 link May 29, 2018
@codecov-io
Copy link

codecov-io commented May 29, 2018 •
edited
Loading

Codecov Report

Merging #4077 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4077   +/-   ##
=======================================
  Coverage   19.97%   19.97%           
=======================================
  Files         153      153           
  Lines       30491    30491           
=======================================
  Hits         6091     6091           
  Misses      23486    23486           
  Partials      914      914

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af05212...4539918. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 29, 2018
@lunny
Copy link
Member

lunny commented May 30, 2018

LGTM

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 30, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 30, 2018
@lunny lunny added this to the 1.5.0 milestone May 30, 2018
@techknowlogick techknowlogick merged commit 728cc27 into go-gitea:master May 30, 2018
@techknowlogick techknowlogick deleted the techknowlogick-patch-2 branch May 30, 2018 22:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@techknowlogick @codecov-io @lunny @appleboy @bkcsoft