-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request review/approval and comment on code #3748
Commits on May 6, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 85e1ad5 - Browse repository at this point
Copy the full SHA 85e1ad5View commit details -
Add IssueComment types Signed-off-by: Jonas Franz <info@jonasfranz.software> (cherry picked from commit 2b4daab) Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 623a9f6 - Browse repository at this point
Copy the full SHA 623a9f6View commit details -
Replace ReviewComment with Content
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for aeb0577 - Browse repository at this point
Copy the full SHA aeb0577View commit details
Commits on May 10, 2018
-
Add ReviewID to findComments Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 2c18552 - Browse repository at this point
Copy the full SHA 2c18552View commit details -
Add create review comment implementation
Add migration for review Other small changes Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 9544c46 - Browse repository at this point
Copy the full SHA 9544c46View commit details -
Simplified create and find functions for review
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 0f772d1 - Browse repository at this point
Copy the full SHA 0f772d1View commit details -
Moved "Pending" to first position
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 4ad563d - Browse repository at this point
Copy the full SHA 4ad563dView commit details -
Add GetCurrentReview to simplify fetching current review
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 17af2d1 - Browse repository at this point
Copy the full SHA 17af2d1View commit details
Commits on May 11, 2018
-
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 75b7d9b - Browse repository at this point
Copy the full SHA 75b7d9bView commit details -
Move new comment form to its own file
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for e252d3b - Browse repository at this point
Copy the full SHA e252d3bView commit details -
Show Review comments on comment stream Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 3e5f3c3 - Browse repository at this point
Copy the full SHA 3e5f3c3View commit details -
Add support for single comments
Showing buttons in context Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 61cc134 - Browse repository at this point
Copy the full SHA 61cc134View commit details -
Add pending tag to pending review comments
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 36d6631 - Browse repository at this point
Copy the full SHA 36d6631View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 9c6bb4b - Browse repository at this point
Copy the full SHA 9c6bb4bView commit details -
Add unit tests Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for bc93592 - Browse repository at this point
Copy the full SHA bc93592View commit details
Commits on May 12, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 58fb672 - Browse repository at this point
Copy the full SHA 58fb672View commit details -
Improved comment rendering in "Files" view by adding Comments to Diff…
…Line Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 066086c - Browse repository at this point
Copy the full SHA 066086cView commit details
Commits on May 13, 2018
-
Add support for invalidating comments
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 7986d6e - Browse repository at this point
Copy the full SHA 7986d6eView commit details -
Switched back to code.gitea.io/git
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for cbdd8c9 - Browse repository at this point
Copy the full SHA cbdd8c9View commit details -
Merge pull request #2 from JonasFranzDEV/feat/approval
Reviews and Pull Request comments
Configuration menu - View commit details
-
Copy full SHA for 2f46613 - Browse repository at this point
Copy the full SHA 2f46613View commit details -
Merge branch 'master' into feat/approval-new
# Conflicts: # models/issue_comment.go # models/migrations/migrations.go # models/migrations/v64.go # models/models.go # public/css/index.css
Configuration menu - View commit details
-
Copy full SHA for 6d00c1a - Browse repository at this point
Copy the full SHA 6d00c1aView commit details -
Moved review migration from v64 to v65
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 7723e15 - Browse repository at this point
Copy the full SHA 7723e15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 90d9dda - Browse repository at this point
Copy the full SHA 90d9ddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5f55ede - Browse repository at this point
Copy the full SHA 5f55edeView commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for d2b4347 - Browse repository at this point
Copy the full SHA d2b4347View commit details
Commits on May 14, 2018
-
Fix unit tests by updating fixtures and updating outdated test
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for ed695c1 - Browse repository at this point
Copy the full SHA ed695c1View commit details -
Comments will be shown at the right place now
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for de7081c - Browse repository at this point
Copy the full SHA de7081cView commit details -
Add support for deleting CodeComments
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 7c4bf56 - Browse repository at this point
Copy the full SHA 7c4bf56View commit details -
Fix problems caused by files in subdirectories
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 6ae32b2 - Browse repository at this point
Copy the full SHA 6ae32b2View commit details
Commits on May 15, 2018
-
Add support for showing code comments of reviews in conversation
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 4ea74e5 - Browse repository at this point
Copy the full SHA 4ea74e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7c1edf9 - Browse repository at this point
Copy the full SHA 7c1edf9View commit details -
Add support for "Show/Hide outdated"
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 8bb5113 - Browse repository at this point
Copy the full SHA 8bb5113View commit details
Commits on May 17, 2018
-
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 5c2171e - Browse repository at this point
Copy the full SHA 5c2171eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f64dad - Browse repository at this point
Copy the full SHA 0f64dadView commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 6e55557 - Browse repository at this point
Copy the full SHA 6e55557View commit details
Commits on May 19, 2018
-
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 05df5a7 - Browse repository at this point
Copy the full SHA 05df5a7View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for e5bde14 - Browse repository at this point
Copy the full SHA e5bde14View commit details -
Merge branch 'master' into feat/approval-new
# Conflicts: # models/error.go # models/migrations/migrations.go # models/models.go # public/js/index.js
Configuration menu - View commit details
-
Copy full SHA for a8dc699 - Browse repository at this point
Copy the full SHA a8dc699View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ea8209 - Browse repository at this point
Copy the full SHA 8ea8209View commit details
Commits on May 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a550052 - Browse repository at this point
Copy the full SHA a550052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f88cb8 - Browse repository at this point
Copy the full SHA 0f88cb8View commit details
Commits on May 22, 2018
-
Merge branch 'master' into feat/approval
# Conflicts: # vendor/vendor.json
Configuration menu - View commit details
-
Copy full SHA for e60b3f6 - Browse repository at this point
Copy the full SHA e60b3f6View commit details
Commits on May 23, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a05d052 - Browse repository at this point
Copy the full SHA a05d052View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27c488e - Browse repository at this point
Copy the full SHA 27c488eView commit details
Commits on May 24, 2018
-
Fix ui bug reported by @lunny causing wrong position of add button
Add functionality to "Cancel" button Add scale effects to add button Hide "Cancel" button for existing comments Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 2b6001b - Browse repository at this point
Copy the full SHA 2b6001bView commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for d25df5b - Browse repository at this point
Copy the full SHA d25df5bView commit details -
Merge branch 'master' into feat/approval-new
# Conflicts: # models/migrations/migrations.go
Configuration menu - View commit details
-
Copy full SHA for 7592f5b - Browse repository at this point
Copy the full SHA 7592f5bView commit details -
Show add button only if no comments already exist for the line
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 4cb3a60 - Browse repository at this point
Copy the full SHA 4cb3a60View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for f64f8e0 - Browse repository at this point
Copy the full SHA f64f8e0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f07b4e1 - Browse repository at this point
Copy the full SHA f07b4e1View commit details
Commits on May 25, 2018
-
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 4ad72de - Browse repository at this point
Copy the full SHA 4ad72deView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2f60f4 - Browse repository at this point
Copy the full SHA e2f60f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 229129d - Browse repository at this point
Copy the full SHA 229129dView commit details -
Show forms only to users who are logged in
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for c083682 - Browse repository at this point
Copy the full SHA c083682View commit details
Commits on May 29, 2018
-
Revert "Show forms only to users who are logged in"
This reverts commit c083682 Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for c7dffe6 - Browse repository at this point
Copy the full SHA c7dffe6View commit details
Commits on May 31, 2018
-
Render patch for code comments Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 4d0abce - Browse repository at this point
Copy the full SHA 4d0abceView commit details -
Configuration menu - View commit details
-
Copy full SHA for c79e5a1 - Browse repository at this point
Copy the full SHA c79e5a1View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 39fcc99 - Browse repository at this point
Copy the full SHA 39fcc99View commit details -
Add reply form to comment list
Show forms only to signed in users Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 9a0c394 - Browse repository at this point
Copy the full SHA 9a0c394View commit details -
Add CODE_COMMENT_LINES setting Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for c8c1e70 - Browse repository at this point
Copy the full SHA c8c1e70View commit details -
Configuration menu - View commit details
-
Copy full SHA for 853ed7d - Browse repository at this point
Copy the full SHA 853ed7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b6d8aea - Browse repository at this point
Copy the full SHA b6d8aeaView commit details -
Configuration menu - View commit details
-
Copy full SHA for e3f87a9 - Browse repository at this point
Copy the full SHA e3f87a9View commit details -
Fix problems introduced by checking for singed in user
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 3f48c7c - Browse repository at this point
Copy the full SHA 3f48c7cView commit details
Commits on Jul 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b4e43d6 - Browse repository at this point
Copy the full SHA b4e43d6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 45dabaf - Browse repository at this point
Copy the full SHA 45dabafView commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for b553556 - Browse repository at this point
Copy the full SHA b553556View commit details -
Beginn with new review comment patch system Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 73b325c - Browse repository at this point
Copy the full SHA 73b325cView commit details
Commits on Jul 6, 2018
-
Add new algo to generate diff for line range
Remove old algo used for cutting big diffs (it was very buggy)
Configuration menu - View commit details
-
Copy full SHA for 3cd5ee4 - Browse repository at this point
Copy the full SHA 3cd5ee4View commit details -
Merge branch 'master' of https://github.com/go-gitea/gitea into feat/…
…approval-new Add additional benchmarks and gofmt
Configuration menu - View commit details
-
Copy full SHA for 7f0eb69 - Browse repository at this point
Copy the full SHA 7f0eb69View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a84f04 - Browse repository at this point
Copy the full SHA 8a84f04View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbaeb02 - Browse repository at this point
Copy the full SHA fbaeb02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5dd39d3 - Browse repository at this point
Copy the full SHA 5dd39d3View commit details -
Configuration menu - View commit details
-
Copy full SHA for aee593b - Browse repository at this point
Copy the full SHA aee593bView commit details -
Send notifications / actions to users until review gets published
Fix diff generation bug Fix wrong hashtag
Configuration menu - View commit details
-
Copy full SHA for 8f77329 - Browse repository at this point
Copy the full SHA 8f77329View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8ddade - Browse repository at this point
Copy the full SHA d8ddadeView commit details -
Configuration menu - View commit details
-
Copy full SHA for dbc7aee - Browse repository at this point
Copy the full SHA dbc7aeeView commit details -
Configuration menu - View commit details
-
Copy full SHA for a0d9afd - Browse repository at this point
Copy the full SHA a0d9afdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b2092fe - Browse repository at this point
Copy the full SHA b2092feView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3013c0c - Browse repository at this point
Copy the full SHA 3013c0cView commit details
Commits on Jul 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 858345d - Browse repository at this point
Copy the full SHA 858345dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e340181 - Browse repository at this point
Copy the full SHA e340181View commit details
Commits on Jul 9, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 3f39e23 - Browse repository at this point
Copy the full SHA 3f39e23View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6de1f38 - Browse repository at this point
Copy the full SHA 6de1f38View commit details
Commits on Jul 20, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 65d4318 - Browse repository at this point
Copy the full SHA 65d4318View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for e7b2b61 - Browse repository at this point
Copy the full SHA e7b2b61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a6e6dc - Browse repository at this point
Copy the full SHA 8a6e6dcView commit details -
Regenerated CSS with latest less version
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 5554ad2 - Browse repository at this point
Copy the full SHA 5554ad2View commit details
Commits on Jul 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b29e722 - Browse repository at this point
Copy the full SHA b29e722View commit details -
Fix test by updating comment type to new ID
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for cb29fdb - Browse repository at this point
Copy the full SHA cb29fdbView commit details
Commits on Jul 24, 2018
-
Introducing CodeComments as type for map[string]map[int64][]*Comment
Other minor code improvements Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 021f028 - Browse repository at this point
Copy the full SHA 021f028View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 5539c96 - Browse repository at this point
Copy the full SHA 5539c96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7eec104 - Browse repository at this point
Copy the full SHA 7eec104View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for ce07867 - Browse repository at this point
Copy the full SHA ce07867View commit details -
refactored checkForInvalidation
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for dc4a27d - Browse repository at this point
Copy the full SHA dc4a27dView commit details -
Append comments instead of setting
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 4c76cf5 - Browse repository at this point
Copy the full SHA 4c76cf5View commit details
Commits on Jul 25, 2018
-
Use HeadRepo instead of BaseRepo
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 77caec7 - Browse repository at this point
Copy the full SHA 77caec7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f1a3e6f - Browse repository at this point
Copy the full SHA f1a3e6fView commit details
Commits on Jul 27, 2018
-
Configuration menu - View commit details
-
Copy full SHA for a116913 - Browse repository at this point
Copy the full SHA a116913View commit details -
Configuration menu - View commit details
-
Copy full SHA for 64269ef - Browse repository at this point
Copy the full SHA 64269efView commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 7888318 - Browse repository at this point
Copy the full SHA 7888318View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 638ea14 - Browse repository at this point
Copy the full SHA 638ea14View commit details
Commits on Aug 5, 2018
-
Configuration menu - View commit details
-
Copy full SHA for c503a70 - Browse repository at this point
Copy the full SHA c503a70View commit details -
Signed-off-by: Jonas Franz <info@jonasfranz.software>
Configuration menu - View commit details
-
Copy full SHA for 5f8c9a2 - Browse repository at this point
Copy the full SHA 5f8c9a2View commit details