Skip to content

Align issue-title-buttons with list-header #35018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jul 9, 2025

This change concerns the "Edit" and "New Issue" button on top right. With this change, switching from the issue list into an issue, the "New Issue" button will no longer "shift" from the postion on the previous page.

Screenshot 2025-07-09 at 17 37 31 Screenshot 2025-07-09 at 17 37 19

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2025
@silverwind silverwind added the backport/v1.24 This PR should be backported to Gitea 1.24 label Jul 9, 2025
@silverwind
Copy link
Member Author

silverwind commented Jul 10, 2025

Found a slightly better fix. By removing align-items: center from the parent, we achieve the same outcome of start-aligned flex children.

@silverwind silverwind changed the title Align issue-title-buttons Align issue-title-buttons with list-header Jul 10, 2025
@wxiaoguang
Copy link
Contributor

Then it mis-aligns

image

@silverwind
Copy link
Member Author

silverwind commented Jul 11, 2025

I guess we can attempt to center single-line title with the buttons. Button position is fine, so the text has to move.

@wxiaoguang
Copy link
Contributor

-> Refactor view issue & comment list styles #35061

@silverwind
Copy link
Member Author

silverwind commented Jul 14, 2025

#35061 does not do anything regarding the "New Issue" button moving down when navigating from issue list to issue.

@wxiaoguang
Copy link
Contributor

Really? After "merge with main branch", this PR doesn't provide any other changes.

image image

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jul 14, 2025

And I don't think it is a must to align components between pages.

For example: if there is "pinned issues", then the "New Issue" button also jumps.


If you'd like to align "everything", you need to align the issue list page's top search bar (including the search input and "New Issue" button) and the issue title line, to make them have the same "visual" height and "visually" center aligned.

@silverwind
Copy link
Member Author

Pushed a different tweak, now text is centered and button does not shift on page switch. And yes I'm only optimizing the common case with no pins and no recently-pushed notice.

image

@silverwind
Copy link
Member Author

Also fixed the title edit toggle, nothing shifts and I was able to remove another unnecessary css rule.

@silverwind silverwind removed the backport/v1.24 This PR should be backported to Gitea 1.24 label Jul 14, 2025
@silverwind
Copy link
Member Author

#35061 was not backported, so this likely can't either.

Signed-off-by: silverwind <me@silverwind.io>
Signed-off-by: silverwind <me@silverwind.io>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 14, 2025
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 1 This PR needs approval from one additional maintainer to be merged. modifies/frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants