-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Align issue-title-buttons
with list-header
#35018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Found a slightly better fix. By removing |
issue-title-buttons
issue-title-buttons
with list-header
I guess we can attempt to center single-line title with the buttons. Button position is fine, so the text has to move. |
-> Refactor view issue & comment list styles #35061 |
#35061 does not do anything regarding the "New Issue" button moving down when navigating from issue list to issue. |
And I don't think it is a must to align components between pages. For example: if there is "pinned issues", then the "New Issue" button also jumps. If you'd like to align "everything", you need to align the issue list page's top search bar (including the search input and "New Issue" button) and the issue title line, to make them have the same "visual" height and "visually" center aligned. |
Also fixed the title edit toggle, nothing shifts and I was able to remove another unnecessary css rule. |
#35061 was not backported, so this likely can't either. |
Signed-off-by: silverwind <me@silverwind.io>
Signed-off-by: silverwind <me@silverwind.io>
This change concerns the "Edit" and "New Issue" button on top right. With this change, switching from the issue list into an issue, the "New Issue" button will no longer "shift" from the postion on the previous page.