Add the ability to use multiple labels as filters #3438

erjiaqing · 2018-01-31T13:09:29Z

Implements Issue #3430

As in GitHub, when selecting multiple labels, only display those issues with all the labels selected.

I cannot figure out how to achieve this using the orm provided, so I write a subquery.

Then I use Label.QueryString and Label.IsSelected for the query string(issues?labels=xxx) and the tick before labels.

jonasfranz · 2018-02-02T19:23:31Z

models/issue_label.go

@@ -76,6 +78,25 @@ func (label *Label) CalOpenIssues() {
 	label.NumOpenIssues = label.NumIssues - label.NumClosedIssues
 }

+// CalQueryString calculates query string in issue/pulls list
+func (label *Label) CalQueryString(query []string) {


You should rename query []string to labels []string.
I think that the function name is not very self-explanatory at the first place. It should be renamed into RestoreSelectedLabels or LoadSelectedLabelsFromQuery.

erjiaqing · 2018-02-03T06:19:10Z

In GitHub, when multiple labels are selected, only issues with all of the selected labels will be shown. However, in test, it is assumed that issues with at least one of the selected labels will be shown.
Maybe I have to change the tests?

when multiple labels selected, only issues with all the selected labels will be shown

ernierasta · 2018-05-22T11:28:24Z

Drone will not show, what is the problem with CI... so I have no idea how serious problem with this commit is ...

This would be life saver, is there reason why it is not merged?
Can we make it merge? ;-)

to describe why the result is {1} instead of {5, 2, 1}

erjiaqing · 2018-05-22T12:28:36Z

I could remember that the last time, it reports that my commit cannot pass the unit test
it is because that:

 			IssuesOptions{
 				Labels:   "1,2",
 				Page:     1,
 				PageSize: 4,
 			},
-			[]int64{5, 2, 1},
+			[]int64{1}, // issues with **both** label 1 and 2, only issue 1 matches
 		},

I made a net commit, and it should pass the test now, and this time, it reports another failure
I have no idea about this, maybe the structure of database had changed a lot
@ernierasta
(I don't know if you will be notified for this)

codecov-io · 2018-05-22T13:24:10Z

Codecov Report

❗ No coverage uploaded for pull request base (master@45f3d4a). Click here to learn what that means.
The diff coverage is 13.63%.

@@            Coverage Diff            @@
##             master    #3438   +/-   ##
=========================================
  Coverage          ?   20.11%           
=========================================
  Files             ?      153           
  Lines             ?    30393           
  Branches          ?        0           
=========================================
  Hits              ?     6114           
  Misses            ?    23372           
  Partials          ?      907

Impacted Files	Coverage Δ
routers/repo/issue_label.go	`42.76% <0%> (ø)`
models/issue.go	`32.06% <11.76%> (ø)`
models/issue_label.go	`56.1% <30.76%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45f3d4a...5f08f1b. Read the comment docs.

lafriks · 2018-05-22T16:46:13Z

models/issue.go

+		} else if len(labelIDs) > 1 {
+			cond, args, _ := builder.ToSQL(builder.In("issue_label.label_id", labelIDs))
+			sess.
+				Where(fmt.Sprintf(`issue.id IN (


Can't this be built using builder? cc: @lunny

yasuokav · 2018-06-30T14:29:49Z

https://github.com/erjiaqing/gitea/blob/5f08f1bc0ac685c8e0fd983ca652ee363625395f/templates/repo/issue/list.tmpl#L135

<span class="octicon {{if eq $.SelectLabels .ID}}octicon-check{{end}}"></span><span class="label color" style="background-color: {{.Color}}"></span> {{.Name}}

eq $.SelectLabels .ID -> .IsSelected?

https://github.com/erjiaqing/gitea/blob/5f08f1bc0ac685c8e0fd983ca652ee363625395f/routers/repo/issue.go#L243

ctx.Data["SelectLabels"] = com.StrTo(selectLabels).MustInt64()

selectLabels is no longer an int

bkcsoft · 2018-07-09T00:09:30Z

models/issue.go

@@ -1322,9 +1332,19 @@ func GetIssueStats(opts *IssueStatsOptions) (*IssueStats, error) {
 			labelIDs, err := base.StringsToInt64s(strings.Split(opts.Labels, ","))
 			if err != nil {
 				log.Warn("Malformed Labels argument: %s", opts.Labels)
-			} else if len(labelIDs) > 0 {
+			} else if len(labelIDs) == 1 {


This query could be fixed to do > 0 instead of having 2 different queries

stale · 2019-01-05T06:44:33Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

stale · 2019-01-19T07:35:14Z

This pull request has been automatically closed because of inactivity. You can re-open it if needed.

erjiaqing added 2 commits January 31, 2018 20:42

Add the ability to use multiple labels as filters (go-gitea#3430)

0d10b62

to fix a bug when select only one label

e33b02e

lunny added the type/enhancement An improvement of existing functionality label Jan 31, 2018

lunny added this to the 1.x.x milestone Jan 31, 2018

fix format

01252ba

jonasfranz suggested changes Feb 2, 2018

View reviewed changes

tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 2, 2018

rename some variables and functions

5d80044

erjiaqing closed this Feb 3, 2018

erjiaqing reopened this Feb 3, 2018

update tests to match expected value

ccf7056

when multiple labels selected, only issues with all the selected labels will be shown

Update issue_test.go

35e0f5b

to describe why the result is {1} instead of {5, 2, 1}

fix test

5f08f1b

erjiaqing force-pushed the issue_3430 branch from a42c811 to 5f08f1b Compare May 22, 2018 13:13

lafriks reviewed May 22, 2018

View reviewed changes

bkcsoft reviewed Jul 9, 2018

View reviewed changes

stale bot added the issue/stale label Jan 5, 2019

stale bot closed this Jan 19, 2019

lafriks mentioned this pull request Jan 20, 2019

Add the ability to use multiple labels as filters #5786

Merged

lafriks removed this from the 1.x.x milestone Jan 21, 2019

jaqra mentioned this pull request Oct 19, 2019

Add 'Alt + click' feature to exclude labels #8199

Merged

go-gitea locked and limited conversation to collaborators Nov 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the ability to use multiple labels as filters #3438

Add the ability to use multiple labels as filters #3438

erjiaqing commented Jan 31, 2018

jonasfranz Feb 2, 2018

erjiaqing commented Feb 3, 2018

ernierasta commented May 22, 2018

erjiaqing commented May 22, 2018

codecov-io commented May 22, 2018

lafriks May 22, 2018

yasuokav commented Jun 30, 2018

bkcsoft Jul 9, 2018

stale bot commented Jan 5, 2019

stale bot commented Jan 19, 2019

Add the ability to use multiple labels as filters #3438

Add the ability to use multiple labels as filters #3438

Conversation

erjiaqing commented Jan 31, 2018

jonasfranz Feb 2, 2018

Choose a reason for hiding this comment

erjiaqing commented Feb 3, 2018

ernierasta commented May 22, 2018

erjiaqing commented May 22, 2018

codecov-io commented May 22, 2018

Codecov Report

lafriks May 22, 2018

Choose a reason for hiding this comment

yasuokav commented Jun 30, 2018

bkcsoft Jul 9, 2018

Choose a reason for hiding this comment

stale bot commented Jan 5, 2019

stale bot commented Jan 19, 2019