Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run goimports on the whole project #34

Merged
merged 1 commit into from
Nov 4, 2016
Merged

Run goimports on the whole project #34

merged 1 commit into from
Nov 4, 2016

Conversation

metalmatze
Copy link
Contributor

When opening this repository in my editor, I run goimports automatically. This is what it found.

@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

LGTM

1 similar comment
@lunny
Copy link
Member

lunny commented Nov 3, 2016

LGTM

@strk
Copy link
Member

strk commented Nov 3, 2016

Could you please rebase and fix conflicts ?

@xinity xinity added the type/enhancement An improvement of existing functionality label Nov 3, 2016
@xinity xinity added this to the 1.0.0 milestone Nov 3, 2016
@tboerger
Copy link
Member

tboerger commented Nov 3, 2016

Please rebase as @strk mentioned.

"testing"

"bytes"
. "github.com/gogits/gogs/modules/markdown"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

"testing"

"bytes"
. "github.com/gogits/gogs/modules/markdown"
"github.com/gogits/gogs/modules/setting"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope

"testing"

. "github.com/gogits/gogs/models"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be changed

"testing"

. "github.com/gogits/gogs/models"
"github.com/gogits/gogs/modules/markdown"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this

Signed-off-by: Matthias Loibl <mail@matthiasloibl.com>
@codecov-io
Copy link

codecov-io commented Nov 4, 2016

Current coverage is 2.18% (diff: 100%)

Merging #34 into master will not change coverage

@@            master       #34   diff @@
========================================
  Files           31        31          
  Lines         7508      7508          
  Methods          0         0          
  Messages         0         0          
  Branches         0         0          
========================================
  Hits           164       164          
  Misses        7327      7327          
  Partials        17        17          

Powered by Codecov. Last update fc55182...f19e9a9

@metalmatze
Copy link
Contributor Author

Recreated the commit with the current master.
Wrong import paths are gone too. Sorry @bkcsoft.

@andreynering andreynering merged commit a4fa889 into go-gitea:master Nov 4, 2016
@metalmatze metalmatze deleted the feature/goimports branch November 4, 2016 23:56
@tboerger tboerger added the lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. label Nov 29, 2016
lunny added a commit to lunny/gitea that referenced this pull request Feb 7, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants