Update mermaid to v11 #31913
Merged
Update mermaid to v11 #31913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/XS
GiteaBot
added
the
lgtm/need 2
lunny
approved these changes
Aug 24, 2024
GiteaBot
added
lgtm/need 1
wolfogre
approved these changes
Aug 25, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Aug 26, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores Update mermaid to v11 (go-gitea#31913) Handle "close" actionable references for manual merges (go-gitea#31879) [skip ci] Updated translations via Crowdin Remove "dsa-1024" testcases from Test_SSHParsePublicKey and Test_calcFingerprint (go-gitea#31905)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update mermaid to v11 and enable the new
suppressErrorRenderingoption to ensure mermaid never renders error elements into the DOM (we have per-chart error rendering, so don't need it). Tested various chart types.BTW, I was unable to reproduce that error rendering from mermaid with
suppressErrorRendering: falseand I thought we had some CSS to hide the error element, but I could not find it, not even in git history.