Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct function name #31887

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Use correct function name #31887

merged 2 commits into from
Aug 21, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 20, 2024

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 20, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 20, 2024
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 20, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Aug 20, 2024
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 20, 2024
@techknowlogick
Copy link
Member

should this be backported?

@lunny
Copy link
Member Author

lunny commented Aug 20, 2024

should this be backported?

I don't think so.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 21, 2024
@lunny lunny enabled auto-merge (squash) August 21, 2024 18:08
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2024
@lunny lunny merged commit 0299bb9 into go-gitea:main Aug 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 21, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 21, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 24, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8a4eb2d 
* giteaofficial/main:
  Bump relative-time-element to v4.4.3 (go-gitea#31910)
  [skip ci] Updated translations via Crowdin
  Use correct function name (go-gitea#31887)
  Move lock icon position and add additional tooltips to branch list page (go-gitea#31839)
  Don't return 500 if mirror url contains special chars (go-gitea#31859)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kemzeb kemzeb kemzeb approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @techknowlogick @lafriks @kemzeb @GiteaBot