Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the component of access token list not mounted #31824

Merged
merged 7 commits into from
Aug 16, 2024
Merged

fix the component of access token list not mounted #31824

merged 7 commits into from
Aug 16, 2024

Conversation

sillyguodong
Copy link
Contributor

@sillyguodong sillyguodong commented Aug 13, 2024 •
edited
Loading

try to fix #31771

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 13, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2024
@sillyguodong
Copy link
Contributor Author

#31771 (comment)
@wxiaoguang @silverwind what are your thoughts on this?

@wxiaoguang
Copy link
Contributor

Not right

@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Aug 14, 2024
@sillyguodong
Copy link
Contributor Author

@wxiaoguang
ba52d01 no longer import the createApp in the SFC. I believe the Vue component will be compiled during the build stage. Is this right now?

@wxiaoguang
Copy link
Contributor

Overall right.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 14, 2024
@lunny lunny mentioned this pull request Aug 14, 2024
Closed
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 16, 2024
@proxity
Copy link

proxity commented Aug 16, 2024

It's a pity that the feature is broken in 1.22.1. Will you merge the fix?

@lunny lunny added reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. backport/v1.22 This PR should be backported to Gitea 1.22 labels Aug 16, 2024
@lunny lunny enabled auto-merge (squash) August 16, 2024 16:36
@lunny
Copy link
Member

lunny commented Aug 16, 2024

It's a pity that the feature is broken in 1.22.1. Will you merge the fix?

Yes, this will be backport to 1.22.2

@lunny lunny merged commit 2e7d202 into go-gitea:main Aug 16, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Aug 16, 2024
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.22. @sillyguodong, please send one manually. 🍵

go run ./contrib/backport 31824
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Aug 16, 2024
@sillyguodong
Copy link
Contributor Author

I was unable to create a backport for 1.22. @sillyguodong, please send one manually. 🍵

go run ./contrib/backport 31824
...  // fix git conflicts if any
go run ./contrib/backport --continue

i will take a look

zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 19, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8de67cb 
* giteaofficial/main:
  [skip ci] Updated translations via Crowdin
  [skip ci] Updated translations via Crowdin
  Fix overflowing content in action run log (go-gitea#31842)
  Upgrade `htmx` to `2.0.2` (go-gitea#31847)
  fix the component of access token list not mounted (go-gitea#31824)
  Avoid returning without written ctx when posting PR (go-gitea#31843)
  Fix raw wiki links (go-gitea#31825)
sillyguodong added a commit to sillyguodong/gitea that referenced this pull request Aug 19, 2024
@sillyguodong
fix the component of access token list not mounted (go-gitea#31824)
6a06094 
try to fix go-gitea#31771
@sillyguodong sillyguodong mentioned this pull request Aug 19, 2024
Merged
techknowlogick pushed a commit that referenced this pull request Aug 19, 2024
@sillyguodong
fix the component of access token list not mounted (#31824) (#31868)
5d2afc6
@lunny lunny added the backport/done All backports for this PR have been created label Aug 21, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js modifies/templates This PR modifies the template files size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

scoped-access-token-mount not mounted anymore
6 participants
@sillyguodong @wxiaoguang @proxity @lunny @GiteaBot @wolfogre