Fix large image overflow in comment page #31740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/XS
|
Why this is related to the avatar's size/location? |
|
Hmm I need to check this, but my feeling is that the fix is wrong and we should not need to specify any pixel values. How to reproduce, just a overly large image? |
|
The actual problem is this CSS: 
Setting |
|
The proper fix should be this
|
github-actions
bot
added
the
modifies/templates
wxiaoguang
approved these changes
Nov 15, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Nov 15, 2024
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 17, 2024
* giteaofficial/main: Fix basic auth with webauthn (go-gitea#32531) Fix and refactor markdown rendering (go-gitea#32522) Fix large image overflow in comment page (go-gitea#31740) Improve testing and try to fix MySQL hanging (go-gitea#32515) Fix `recentupdate` sorting bugs (go-gitea#32505)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #31709
52px is calculate by avatar size in templates\repo\issue\view_content\comments.tmpl