Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split common-global.js into separate files #31438

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Split common-global.js into separate files #31438

merged 2 commits into from
Jun 21, 2024

Conversation

wxiaoguang
Copy link
Contributor

To improve maintainability

@wxiaoguang wxiaoguang added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Jun 20, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2024
@pull-request-size pull-request-size bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 20, 2024
@silverwind
Copy link
Member

silverwind commented Jun 20, 2024 •
edited
Loading

Can we do web_src/js/common/button.js scheme please? I think the amount of files in features is too much and unergonomic.

@wxiaoguang
Copy link
Contributor Author

Can we do web_src/js/common/button.js scheme please? I think the amount of files in features is too much and unergonomic.

It does follow the current names: repo-*.js, user-*.js, and now common-*.js.

We could do another round renaming&moving, but this PR is large enough.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 20, 2024
@wxiaoguang
Copy link
Contributor Author

To split the file, it is not simply a copy&paste work, it also changes some code, and when merging with main, there are some conflicts (eg: the htmx.js is moved from common-global to index).

So to make code safe and avoid losing code, I think this PR could be merged as-is. Any renaming&moving work could be done in the future.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2024
@wxiaoguang wxiaoguang merged commit 0678287 into go-gitea:main Jun 21, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 21, 2024
@wxiaoguang wxiaoguang deleted the refactor-js-common-global branch June 21, 2024 07:40
@wxiaoguang wxiaoguang mentioned this pull request Jun 21, 2024
Merged
silverwind added a commit to silverwind/gitea that referenced this pull request Jun 21, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into tsconfig
afa931e 
* origin/main: (21 commits)
  Fix deprecated Dockerfile ENV format (go-gitea#31450)
  README Badge maintenance (go-gitea#31441)
  Improve markdown textarea for indentation and lists (go-gitea#31406)
  Split common-global.js into separate files (go-gitea#31438)
  Fix the link for .git-blame-ignore-revs bypass (go-gitea#31432)
  Bump htmx to 2.0.0 (go-gitea#31413)
  Fix the wrong line number in the diff view page when expanded twice. (go-gitea#31431)
  Fix labels and projects menu overflow on issue page (go-gitea#31435)
  [Fix] Account Linking UpdateMigrationsByType  (go-gitea#31428)
  Fix markdown math brackets render problem (go-gitea#31420)
  Reduce `air` verbosity (go-gitea#31417)
  Fix new issue/pr avatar (go-gitea#31419)
  Increase max length of org team names from 30 to 255 characters (go-gitea#31410)
  [skip ci] Updated translations via Crowdin
  Refactor names (go-gitea#31405)
  Update JS dependencies, remove `eslint-plugin-jquery` (go-gitea#31402)
  Switch to upstream of `gorilla/feeds` (go-gitea#31400)
  Fix rendered wiki page link (go-gitea#31398)
  Refactor repo unit "disabled" check (go-gitea#31389)
  Refactor route path normalization (go-gitea#31381)
  ...
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 22, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
284caa9 
* giteaofficial/main:
  Refactor image diff (go-gitea#31444)
  [skip ci] Updated translations via Crowdin
  Support relative paths to videos from Wiki pages (go-gitea#31061)
  Fix deprecated Dockerfile ENV format (go-gitea#31450)
  README Badge maintenance (go-gitea#31441)
  Improve markdown textarea for indentation and lists (go-gitea#31406)
  Split common-global.js into separate files (go-gitea#31438)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@delvh delvh delvh approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.
5 participants
@wxiaoguang @silverwind @lunny @delvh @GiteaBot