Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rearrange Clone Panel #31142

Merged
merged 19 commits into from
Dec 11, 2024
Merged

Rearrange Clone Panel #31142

merged 19 commits into from
Dec 11, 2024

Conversation

BlenderDefender
Copy link
Contributor

@BlenderDefender BlenderDefender commented May 28, 2024 •
edited by wxiaoguang
Loading

This pull request restores the state of the pull request #23231, unfortunately, changing the pull request head is not possible. Created as draft PR until #27931 is merged in.

Rearrange the clone panel to use less horizontal space. The following changes have been made to achieve this:

  • Moved everything into the dropdown menu
  • Moved the HTTPS/SSH Switch to a separate line and made the buttons larger
  • Added a short description what HTTPS- and SSH-Cloning are for
  • Moved the "Clone in VS Code"-Button up and added a divider to separate cloning and downloading
  • Named the dropdown button "Code", added appropriate icon and made the button a primary button to raise more attention.

Before:
grafik

Current look (needs improvements):

image

This pull requests aims to fix #23202

@BlenderDefender
feat(WIP): Rearrange clone panel
8181d3a 
This commit restores the state of the pull request from March 2023. The result looks different and still needs to be improved.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2024
@github-actions github-actions bot added modifies/translation modifies/templates This PR modifies the template files labels May 28, 2024
@lunny lunny added this to the 1.23.0 milestone May 29, 2024
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label May 29, 2024
@silverwind
Copy link
Member

Created as draft PR until #27931 is merged in

Is it really a dependency?

@silverwind
Copy link
Member

silverwind commented Jun 1, 2024 •
edited
Loading

I would strongly prefer if this would use tippy.js for the dropdown menu because fomantic dropdowns have numerous issues and I would like to remove those eventually.

Take a look how the PR review button is implemented, it needs a tiny bit of glue JS to associate the button with the menu content.

@BlenderDefender
Copy link
Contributor Author

Alright, thanks for the feedback 👍
#27931 isn't a really a dependency in the sense that I could only work on this once it's merged in, but this PR almost certainly breaks the other one. If that's not a problem, I'll continue working on this and mark it ready for review as soon as I'm done.

@silverwind
Copy link
Member

silverwind commented Jun 1, 2024 •
edited
Loading

I guess it shouldn't be blocked by that semi-stale PR. It already has accumlated a number of merge conflicts.

Regarding this topic, I'm kind of neutral. On one side I like the 1-click copy behaviour of the current behaviour, but I guess we need to save space on this section which this button brings.

I suggest moving the search field to the right with this change, to the left side of the code button (Edit: I see your screenshot already does that so 👍)

@techknowlogick techknowlogick marked this pull request as ready for review September 7, 2024 18:53
@techknowlogick
Copy link
Member

ack. sorry for the noise on this PR. I attempted to use the auto-lintfix functionality, but it seems like git isn't accepting the reverted changes for the CSS file.

@techknowlogick
Copy link
Member

I've just converted this to use tippy, although the styling is a bit WIP still

@techknowlogick
Copy link
Member

This is now ready for review.

lunny
lunny reviewed Sep 9, 2024
View reviewed changes
templates/repo/home.tmpl Outdated Show resolved Hide resolved
@techknowlogick
Copy link
Member

@lafriks That spacing has been adjusted and I'll update the screenshot shortly.

@BlenderDefender
Copy link
Contributor Author

@techknowlogick Hey there, thanks for continuing work on this, much appreciated :)

@lunny
Copy link
Member

lunny commented Sep 17, 2024

Looks like something is broken.
图片

@lunny lunny modified the milestones: 1.23.0, 1.24.0 Sep 24, 2024
@wxiaoguang
Copy link
Contributor

@techknowlogick stale?

@wxiaoguang
Copy link
Contributor

Well, no active, I will take it to 1.23

@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Dec 11, 2024
@wxiaoguang
Merge branch 'main' into rearrange-clone-panel
dd8c361 
# Conflicts:
#	templates/repo/home.tmpl
#	web_src/js/index.ts
@wxiaoguang
fix
14b106a
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/frontend and removed modifies/translation labels Dec 11, 2024
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Dec 11, 2024 •
edited
Loading

OK, it should be good enough now. A lot of legacy code could be removed.

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 11, 2024
@wxiaoguang wxiaoguang force-pushed the rearrange-clone-panel branch from 585ae46 to 2102d65 Compare December 11, 2024 09:40
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 11, 2024
@wxiaoguang wxiaoguang merged commit 18061af into go-gitea:main Dec 11, 2024
26 checks passed
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Dec 11, 2024
@lunny lunny mentioned this pull request Dec 11, 2024
Closed
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 12, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
bf641e8 
* giteaofficial/main:
  Switch to `eslint-plugin-import-x` (go-gitea#32790)
  Fix clone panel js error (go-gitea#32798)
  [skip ci] Updated translations via Crowdin
  Add `is_archived` option for issue indexer (go-gitea#32735)
  Upgrade dependency crypto library (go-gitea#32750)
  Add standard-compliant route to serve outdated R packages (go-gitea#32783)
  Fix repo home file list (go-gitea#32788)
  Rearrange Clone Panel (go-gitea#31142)
  Fix a number of typescript errors (go-gitea#32773)
  Add label/author/assignee filters to the user/org home issue list (go-gitea#32779)

# Conflicts:
#	templates/repo/wiki/revision.tmpl
#	templates/repo/wiki/view.tmpl
@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@techknowlogick techknowlogick techknowlogick left review comments

@lunny lunny lunny left review comments

@delvh delvh delvh approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@silverwind silverwind Awaiting requested review from silverwind

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Clone Button Rearrangement
8 participants
@BlenderDefender @silverwind @techknowlogick @lafriks @lunny @wxiaoguang @delvh @GiteaBot