Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve mobile review ui (#31091) #31136

Merged
merged 1 commit into from
May 28, 2024
Merged

Improve mobile review ui (#31091) #31136

merged 1 commit into from
May 28, 2024

Conversation

GiteaBot
Copy link
Contributor

Backport #31091 by @silverwind

Fixes: #31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

Screenshot 2024-05-27 at 02 02 40

After:
Screenshot 2024-05-27 at 01 59 06

@silverwind @GiteaBot
Improve mobile review ui (go-gitea#31091)
0a5c761 
Fixes: go-gitea#31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">
@GiteaBot GiteaBot added the modifies/templates This PR modifies the template files label May 28, 2024
@GiteaBot GiteaBot requested review from delvh and lafriks May 28, 2024 13:41
@GiteaBot GiteaBot added this to the 1.22.1 milestone May 28, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 28, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 28, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2024
@lunny lunny enabled auto-merge (squash) May 28, 2024 13:55
@lunny lunny merged commit b615a59 into go-gitea:release/v1.22 May 28, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@yp05327 yp05327 yp05327 approved these changes

@delvh delvh Awaiting requested review from delvh

@lafriks lafriks Awaiting requested review from lafriks

Assignees

@silverwind silverwind

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
1.22.1
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @lunny @yp05327 @silverwind