Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect object id hash function #30708

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

wxiaoguang
Copy link
Contributor

Great thanks to @oliverpool for figuring out the problem and proposing a fix.

Regression of #28138

Incorrect hash causes the user's LFS files get all deleted when running doctor fix all

(by the way, remove unused/non-standard comments)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 26, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 26, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 26, 2024
@wxiaoguang
Copy link
Contributor Author

@oliverpool I am not a native English speaker, not sure whether such description is right in your mind. If it doesn't look good to you, feel free to provide more details. Thank you.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 26, 2024
@lunny lunny added the type/bug label Apr 26, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 26, 2024
@oliverpool
Copy link
Contributor

Looks good, thanks!

Note that the original reporter invested a lot of time to help us pinpoint the issue and test the fix: https://codeberg.org/forgejo/forgejo/issues/3438 (probably more time than me)

@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 26, 2024
@silverwind silverwind enabled auto-merge (squash) April 26, 2024 08:51
@silverwind silverwind merged commit cd70ab3 into go-gitea:main Apr 26, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Apr 26, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 26, 2024
@wxiaoguang wxiaoguang deleted the fix-obj-hash branch April 26, 2024 10:41
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 26, 2024
* giteaofficial/main:
  feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656)
  Fix code search input for different views (go-gitea#30678)
  Fix incorrect object id hash function (go-gitea#30708)
  Add route handler info for debugging purpose (go-gitea#30705)
  Bump htmx version to 1.9.12 (go-gitea#30711)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 27, 2024
* origin/main:
  Replace deprecated `math/rand` functions (go-gitea#30733)
  Make Ctrl+Enter work for issue/comment edit (go-gitea#30720)
  Rename migration package name for 1.22-rc1 (go-gitea#30730)
  Issue card improvements (go-gitea#30687)
  Don't show loading indicators when refreshing the system status (go-gitea#30712)
  Add some tests to clarify the "must-change-password" behavior (go-gitea#30693)
  Prevent allow/reject reviews on merged/closed PRs (go-gitea#30686)
  Update JS dependencies (go-gitea#30713)
  Improve diff stats bar (go-gitea#30669)
  Remove unused parameter for some functions in `services/mirror` (go-gitea#30724)
  Update misspell to 0.5.1 and add `misspellings.csv` (go-gitea#30573)
  Suppress browserslist warning in webpack target (go-gitea#30571)
  [skip ci] Updated translations via Crowdin
  Diff color enhancements, add line number background (go-gitea#30670)
  feat(api): enhance Actions Secrets Management API for repository (go-gitea#30656)
  Fix code search input for different views (go-gitea#30678)
  Fix incorrect object id hash function (go-gitea#30708)
AdamMajer pushed a commit to AdamMajer/gitea that referenced this pull request May 14, 2024
Great thanks to @oliverpool for figuring out the problem and proposing a
fix.

Regression of go-gitea#28138

Incorrect hash causes the user's LFS files get all deleted when running
`doctor fix all`

(by the way, remove unused/non-standard comments)

Co-authored-by: Giteabot <teabot@gitea.io>
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants