-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change commit page signature indication to icon only #30221
Draft
silverwind
wants to merge
4
commits into
go-gitea:main
Choose a base branch
from
silverwind:sigicon
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+151
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Apr 1, 2024
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Apr 1, 2024
github-actions
bot
added
modifies/translation
modifies/templates
This PR modifies the template files
modifies/js
labels
Apr 1, 2024
silverwind
commented
Apr 1, 2024
{{if .Verification.Reason}} | ||
{{$text = (ctx.Locale.Tr .Verification.Reason)}} | ||
{{else}} | ||
{{$text = (ctx.Locale.Tr "sig_failed")}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this condition can be reached. At least it wasn't necessary before, so maybe can remove.
silverwind
commented
Apr 1, 2024
Should be fixed with 5965d4a, no idea why it didn't error for me 😆 |
WIP because I need to double-check that the logic is same as previous, it's quite convoluted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
modifies/js
modifies/templates
This PR modifies the template files
modifies/translation
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #29641.
Commit page header is now always uncolored and the signature status is shown by a new icon: