Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove jQuery class from the diff view #30176

Merged
merged 7 commits into from
Mar 29, 2024
Merged

Remove jQuery class from the diff view #30176

merged 7 commits into from
Mar 29, 2024

Conversation

yardenshoham
Copy link
Member

  • Switched from jQuery class functions to plain JavaScript classList
  • Tested the diff view functionality and it works as before

@yardenshoham
Remove jQuery class from the diff view
a3fdd0d 
- Switched from jQuery class functions to plain JavaScript `classList`
- Tested the diff view functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 29, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 29, 2024
@yardenshoham yardenshoham added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Mar 29, 2024
silverwind
silverwind reviewed Mar 29, 2024
View reviewed changes
web_src/js/utils/dom.js Outdated Show resolved Hide resolved
yardenshoham and others added 2 commits March 29, 2024 18:25
@yardenshoham @silverwind
Update web_src/js/utils/dom.js
fa57a4b 
Co-authored-by: silverwind <me@silverwind.io>
@yardenshoham
Remove comment
14a797d
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 29, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 29, 2024
@silverwind silverwind enabled auto-merge (squash) March 29, 2024 18:48
@silverwind silverwind merged commit c487a32 into go-gitea:main Mar 29, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 29, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 29, 2024
@yardenshoham yardenshoham deleted the repo-diff-jquery-class branch March 29, 2024 19:09
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 30, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
7a8a44a 
* giteaofficial/main:
  Include encoding in signature payload (go-gitea#30174)
  Add `stylelint-value-no-unknown-custom-properties` and convert stylelint config to js (go-gitea#30117)
  Remove jQuery class from the commit button (go-gitea#30178)
  Remove jQuery class from the diff view (go-gitea#30176)
  Remove jQuery class from the notification count (go-gitea#30172)
  Remove jQuery class from the code range selection (go-gitea#30173)
  Fix:the rounded corners of the folded file are not displayed correctly (go-gitea#29953)
  Add setting to disable user features when user login type is not plain (go-gitea#29615)

# Conflicts:
#	models/user/user.go
@wxiaoguang wxiaoguang removed this from the 1.23.0 milestone Apr 27, 2024
@wxiaoguang wxiaoguang added this to the 1.22.0 milestone Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jun 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/js size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@yardenshoham @silverwind @delvh @wxiaoguang @GiteaBot