webhook tag sha fix (#286) #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not ? |
tboerger
added
the
lgtm/need 1
|
@strk Not sure if we need it for new branches? and yes, need to vendor, but waiting for dep to be merged first :) |
|
ci failed. and it seems your code is not the latest master. |
|
Just bump it with a comment when everything is done. |
bkcsoft
force-pushed
the
bkcsoft/webhook-tag-sha-fix
branch
from
ac3a599
to
d7bfc3c
Compare
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #286
Depends on go-gitea/go-sdk#21
(Don't merge before I've vendored it!)Tag-hooks are pretty useless without specifying which shasum the new tag points at, this PR fixes that :)
Question:
Should we also send the Shasum for "create branch"-events? (need to add another line in that case ^.^ )Yes