Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Code Indexer support wikis too #29726

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

[WIP] Code Indexer support wikis too #29726

wants to merge 20 commits into from

Conversation

6543
Copy link
Member

@6543 6543 commented Mar 11, 2024 •
edited
Loading

close #3670

TODOs:

Followups

  • duplicate shared code between elasticsearch and bleve

Sponsored by Kithara Software GmbH

@6543 6543 added type/feature Completely new functionality. Can only be merged if feature freeze is not active. pr/wip This PR is not ready for review labels Mar 11, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 11, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 11, 2024
6543
6543 commented Mar 11, 2024
View reviewed changes
modules/indexer/code/indexer_test.go
@@ -28,7 +29,7 @@ func TestMain(m *testing.M) {
func testIndexer(name string, t *testing.T, indexer internal.Indexer) {
t.Run(name, func(t *testing.T) {
var repoID int64 = 1
err := index(git.DefaultContext, indexer, repoID)
err := index(git.DefaultContext, indexer, repoID, false)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo: test indexer for wikis

@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 12, 2024
@6543 6543 mentioned this pull request Mar 12, 2024
Open
7 tasks
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Mar 14, 2024
@pull-request-size pull-request-size bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 16, 2024
@6543 6543 changed the title [Blocked] [WIP] Code Indexer support wikis too [WIP] Code Indexer support wikis too Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/docs modifies/go Pull requests that update Go code pr/wip This PR is not ready for review size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requesting search of wiki repos
2 participants
@6543 @GiteaBot