Lazy load object format with command line and don't do it in OpenRepository #29712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/L
wolfogre
approved these changes
Mar 12, 2024
GiteaBot
added
lgtm/need 1
appleboy
approved these changes
Mar 12, 2024
GiteaBot
added
lgtm/done
lunny
added
performance/speed
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 12, 2024
* giteaofficial/main: Some performance optimization on dashboard and issues page (go-gitea#29010) Remove jQuery AJAX from the issue branch reference selection (go-gitea#29722) Lazy load object format with command line and don't do it in OpenRepository (go-gitea#29712) remove repetitive words (go-gitea#29695) Sync branches first (go-gitea#29714) Add a warning for disallowed email domains (go-gitea#29658) Fix inconsistent rendering of block mathematical expressions (go-gitea#29677)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most time, when invoking
git.OpenRepository,objectFormatwill not be used, so it's a waste to invoke commandline to get the object format.This PR make it a lazy operation, only invoke that when necessary.