Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering internal file links in org #29669

Merged
merged 4 commits into from
Mar 10, 2024

Conversation

ankitrgadiya
Copy link
Contributor

The internal links to other files in the repository were not rendering with the Src Prefix (/src/branch-name/file-path). This commit fixes that by using the SrcLink as base if available.

Resolves #29668

The internal links to other files in the repository were not rendering with the
Src Prefix (/src/branch-name/file-path). This commit fixes that by using the
`SrcLink` as base if available.

Resolves go-gitea#29668
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 8, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 8, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 8, 2024
@lunny lunny added type/bug backport/v1.21 This PR should be backported to Gitea 1.21 labels Mar 8, 2024
@yp05327
Copy link
Contributor

yp05327 commented Mar 8, 2024

Can you merge test and testwiki? These 3 functions are almost same.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 10, 2024
@yardenshoham yardenshoham added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Mar 10, 2024
@lafriks lafriks merged commit 5665a02 into go-gitea:main Mar 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.23.0 milestone Mar 10, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Mar 10, 2024
The internal links to other files in the repository were not rendering
with the Src Prefix (/src/branch-name/file-path). This commit fixes that
by using the `SrcLink` as base if available.

Resolves go-gitea#29668
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Mar 10, 2024
KN4CK3R pushed a commit that referenced this pull request Mar 10, 2024
Backport #29669 by @ankitrgadiya

The internal links to other files in the repository were not rendering
with the Src Prefix (/src/branch-name/file-path). This commit fixes that
by using the `SrcLink` as base if available.

Resolves #29668

Co-authored-by: Ankit R Gadiya <git@argp.in>
@lunny lunny modified the milestones: 1.23.0, 1.22.0 Mar 11, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Mar 11, 2024
* giteaofficial/main:
  Use repo object format name instead of detecting from git repository (go-gitea#29702)
  Improve CSV rendering (go-gitea#29638)
  Remove jQuery AJAX from the comment edit history (go-gitea#29703)
  fix: rendering internal file links in org (go-gitea#29669)
  Fix broken webhooks (go-gitea#29690)
  Suppress error from monaco-editor (go-gitea#29684)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relation Paths in Orgmode don't get the Src Prefix
7 participants