Remove jQuery AJAX from common global functions #29528
Conversation
- Removed all jQuery AJAX calls and replaced with our fetch wrapper - Tested the locale change functionality and it works as before - Tested the delete button functionality and it works as before Signed-off-by: Yarden Shoham <git@yardenshoham.com>
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
yardenshoham
added
the
type/refactoring
GiteaBot
added
lgtm/need 1
GiteaBot
added
lgtm/done
yardenshoham
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
* giteaofficial/main: Actions Artifacts v4 backend (go-gitea#28965) Remove jQuery AJAX from common global functions (go-gitea#29528) Allow options to disable user gpg keys configuration from the interface on app.ini (go-gitea#29486) [skip ci] Updated translations via Crowdin Fix issue & comment history bugs (go-gitea#29525) Fix incorrect diff expander for deletion of last lines in a file (go-gitea#29501) Ignore `__debug_bin*` which is generated by vscode when debugging (go-gitea#29524)
| $.get($this.data('url')).always(() => { | ||
| window.location.reload(); | ||
| }); | ||
| await GET($this.data('url')); |
There was a problem hiding this comment.
It's not right to use GET here.
Now the language switch doesn't reload the page due to error: Uncaught (in promise) TypeError: NetworkError when attempting to fetch resource.
Update: maybe it is not really a problem. See below new comment.
There was a problem hiding this comment.
Need to wrap it in try I suppose to replicate .always. Or find a better method that does not rely on throwing at all.
There was a problem hiding this comment.
Hmm ... it seems to be a misconfiguration problem on gitea.com.
If there is no misconfiguration, there wouldn't be a problem I guess.
The strange thing is that on gitea.com, the first request succeeds to change the language, but the second redirected response make the JS error.
There was a problem hiding this comment.
The root URL of gitea.com does not go to the gitea instance, maybe that's the problem?
There was a problem hiding this comment.
Thank you for reporting and I will investigate it.
Demo using
fetchinstead of jQuery AJAX