Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue & comment history bugs (#29525) #29527

Merged
merged 1 commit into from
Mar 2, 2024

Conversation

GiteaBot
Copy link
Contributor

@GiteaBot GiteaBot commented Mar 1, 2024

Backport #29525 by @wxiaoguang

  • Follow Improvements to content history #17746: HasIssueContentHistory should use expr builder to make sure zero value (0) be respected.
  • Add "doer" check to make sure canSoftDeleteContentHistory only be called by sign-in users.

* Follow go-gitea#17746: `HasIssueContentHistory` should use expr builder to
make sure zero value (0) be respected.
* Add "doer" check to make sure `canSoftDeleteContentHistory` only be
called by sign-in users.
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 1, 2024
@GiteaBot GiteaBot added this to the 1.21.8 milestone Mar 1, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 1, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 1, 2024
@silverwind silverwind enabled auto-merge (squash) March 1, 2024 16:47
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 2, 2024
@silverwind silverwind merged commit a86d933 into go-gitea:release/v1.21 Mar 2, 2024
27 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants