Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add issue comment when moving issues from one column to another of the project #29311

Merged
merged 17 commits into from
Aug 9, 2024
Merged

Add issue comment when moving issues from one column to another of the project #29311

merged 17 commits into from
Aug 9, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Feb 22, 2024 •
edited
Loading

Fix #27278
Replace #27816

This PR adds a meta-comment for an issue when dragging an issue from one column to another of a project.

image

@lunny lunny added type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Feb 22, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 22, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 22, 2024
yp05327
yp05327 reviewed Feb 22, 2024
View reviewed changes
services/projects/issue.go Outdated Show resolved Hide resolved
@lunny lunny added this to the 1.22.0 milestone Feb 24, 2024
@lunny lunny marked this pull request as ready for review February 24, 2024 04:53
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 24, 2024
@wxiaoguang
Copy link
Contributor

Give me some more time. I will completely remove these annoying "Escape" and "Safe" from the templates.

@wxiaoguang
Copy link
Contributor

-> Refactor Safe modifier #29392

@lunny lunny force-pushed the lunny/add_comment_move_issue_column branch from 4e5ed97 to 5881f9e Compare February 25, 2024 11:19
@lunny lunny modified the milestones: 1.22.0, 1.23.0 Mar 4, 2024
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Mar 16, 2024
This was referenced Mar 31, 2024
Closed
Open
yp05327
yp05327 reviewed May 28, 2024
View reviewed changes
services/projects/issue.go Outdated Show resolved Hide resolved
@lunny lunny force-pushed the lunny/add_comment_move_issue_column branch from f1b942e to b1a2f40 Compare May 28, 2024 03:21
yp05327
yp05327 reviewed Jun 24, 2024
View reviewed changes
services/projects/issue.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 8, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 9, 2024
@lunny lunny enabled auto-merge (squash) August 9, 2024 01:00
@lunny lunny merged commit 791d7fc into go-gitea:main Aug 9, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Aug 9, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 11, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
494abf6 
* giteaofficial/main:
  Show lock owner instead of repo owner on LFS setting page (go-gitea#31788)
  Move repository visibility to danger zone in the settings area (go-gitea#31126)
  [skip ci] Updated translations via Crowdin
  Add types to various low-level functions (go-gitea#31781)
  Add warning message in merge instructions when `AutodetectManualMerge` was not enabled (go-gitea#31805)
  Show latest run when visit /run/latest (go-gitea#31808)
  Fix typo for `LOG_COMPRESSION` in ini (go-gitea#31809)
  Add label `docs-update-needed` for PRs that modify `app.example.ini` (go-gitea#31810)
  Fix `IsObjectExist` with gogit (go-gitea#31790)
  Support compression for Actions logs (go-gitea#31761)
  Add issue comment when moving issues from one column to another of the project (go-gitea#29311)
  [skip ci] Updated translations via Crowdin
  Fix RPM resource leak (go-gitea#31794)
@yp05327 yp05327 mentioned this pull request Sep 19, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang left review comments

@yardenshoham yardenshoham yardenshoham left review comments

@yp05327 yp05327 yp05327 approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/migrations modifies/templates This PR modifies the template files modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/enhancement An improvement of existing functionality type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

Add the column movement information on the timeline of the Issue detail page.
6 participants
@lunny @wxiaoguang @silverwind @yp05327 @yardenshoham @GiteaBot