Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't install playwright twice #29302

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Don't install playwright twice #29302

merged 3 commits into from
Feb 22, 2024

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Feb 21, 2024 •
edited
Loading

  1. playwright/test is already installed as part of deps-frontend on CI which runs before, so it's better to not install it again (on a potentially different version), and just use the version from package.json and add the deps-frontend dependency.
  2. PLAYWRIGHT_DIR is a undefined variable, so I removed it
$ git show c8ded77680db7344c8dc1ccee76bce0b4e02e103 | grep PLAYWRIGHT_DIR
+playwright: $(PLAYWRIGHT_DIR)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 21, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 21, 2024
@silverwind silverwind added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Feb 21, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 21, 2024
@silverwind
Copy link
Member Author

silverwind commented Feb 21, 2024 •
edited
Loading

There is one "flaky" failure in the e2e test but it seems unrelated. Restarting CI.

  1 flaky
    [webkit] › example.test.e2e.js:9:1 › Load Homepage

Edit: 3 in a row so far. Maybe unlucky or something about this PR.

@silverwind
Copy link
Member Author

More weird failures. They may be normal.


  1) [Mobile Safari] › example.test.e2e.js:32:1 › Test Login Form ──────────────────────────────────

    Error: expect(received).toBe(expected) // Object.is equality

    Expected: "http://localhost:3003/"
    Received: "http://localhost:3003/user/login"

@silverwind
Copy link
Member Author

Last run all passed so I'm positive this didn't break it and that the e2e tests are just very flaky/broken.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 22, 2024
@silverwind silverwind added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 22, 2024
@silverwind silverwind enabled auto-merge (squash) February 22, 2024 02:33
@silverwind silverwind merged commit c236e64 into go-gitea:main Feb 22, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Feb 22, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 22, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 23, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
d1e6961 
* giteaofficial/main:
  Start to migrate from `util.OptionalBool` to `optional.Option[bool]` (go-gitea#29329)
  Add slow SQL query warning (go-gitea#27545)
  Unify organizations header (go-gitea#29248)
  Frontport changelogs of minor releases (go-gitea#29337)
  Support SAML authentication (go-gitea#25165)
  Upgrade to fabric 6 (go-gitea#29334)
  Don't show third-party JS errors in production builds (go-gitea#29303)
  Remove bountysource (go-gitea#29330)
  Remove unnecessary "Str2html" modifier from templates (go-gitea#29319)
  Ignore the linux anchor point to avoid linux migrate failure (go-gitea#29295)
  Remove jQuery from the repo commit functions (go-gitea#29230)
  Remove unnecessary "Safe" modifier from templates (go-gitea#29318)
  Remove jQuery from the image pasting functionality (go-gitea#29324)
  Improve the `issue_comment` workflow trigger event (go-gitea#29277)
  Properly migrate automatic merge GitLab comments (go-gitea#27873)
  Refactor cmd setup and remove deadcode (go-gitea#29313)
  small cache when get user id on interation (go-gitea#29296)
  Discard unread data of `git cat-file` (go-gitea#29297)
  Don't install playwright twice (go-gitea#29302)

# Conflicts:
#	templates/home.tmpl
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 1, 2024

Automatically locked because of our CONTRIBUTING guidelines

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/internal size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features.
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@silverwind @wxiaoguang @delvh @GiteaBot