Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement recent commits graph #29210

Merged
merged 16 commits into from
Feb 24, 2024
Merged

Implement recent commits graph #29210

merged 16 commits into from
Feb 24, 2024

Conversation

sahinakkaya
Copy link
Contributor

@sahinakkaya sahinakkaya commented Feb 17, 2024 •
edited
Loading

Overview

This is the implementation of Recent Commits page. This feature was mentioned on #18262.

It adds another tab to Activity page called Recent Commits. Recent Commits tab shows number of commits since last year for the repository.

Before:
image

After:
image

Features

  • See number of commits for each week for the past year
  • Hover over the graph to see a detailed tooltip for that week
  • Use the same cache from Contributors page so that the loading of data will be fast once it is cached by visiting either one of the pages

Issues to consider before merging:

  • Since only last year's data is necessary, we don't need to process whole history of the repository. This implementation currently uses data from "Contributors" page which processes whole history of the repo. If the data is cached before, we are good. If it is not cached, we wait a little bit longer to process whole history. This issue is not important if user wants to visit other pages (contributors, code frequency) because they will need whole data any way.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 17, 2024
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 17, 2024
@sahinakkaya sahinakkaya mentioned this pull request Feb 17, 2024
Closed
@lunny lunny mentioned this pull request Feb 17, 2024
Open
3 tasks
denyskon
denyskon suggested changes Feb 17, 2024
View reviewed changes
options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 17, 2024
@sahinakkaya sahinakkaya mentioned this pull request Feb 18, 2024
Merged
@sahinakkaya sahinakkaya changed the title Recent commits graph Implement recent commits graph Feb 19, 2024
@sahinakkaya sahinakkaya mentioned this pull request Feb 19, 2024
Merged
lunny pushed a commit that referenced this pull request Feb 19, 2024
@sahinakkaya
Deduplicate translations for contributors graph (#29256)
39a77d9 
I have implemented three graph pages
([contributors](#27882), [code
frequency](#29191) and [recent
commits](#29210)) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.
@wxiaoguang wxiaoguang removed the lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged label Feb 19, 2024
DennisRasey pushed a commit to DennisRasey/forgejo that referenced this pull request Feb 20, 2024
@sahinakkaya @earl-warren
Deduplicate translations for contributors graph (#29256)
8125fe0 
I have implemented three graph pages
([contributors](go-gitea/gitea#27882), [code
frequency](go-gitea/gitea#29191) and [recent
commits](go-gitea/gitea#29210)) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.

(cherry picked from commit 39a77d92d9677b0a0049cb8696960d6d2ac052d6)
@6543 6543 added this to the 1.22.0 milestone Feb 20, 2024
silverwind pushed a commit to silverwind/gitea that referenced this pull request Feb 20, 2024
@sahinakkaya @silverwind
Deduplicate translations for contributors graph (go-gitea#29256)
fff4bc2 
I have implemented three graph pages
([contributors](go-gitea#27882), [code
frequency](go-gitea#29191) and [recent
commits](go-gitea#29210)) and they have
all same page title as the tab name so I decided to use same
translations for them. This PR is for contributors graph. Other PR's
have their own respective commits.
@silverwind silverwind mentioned this pull request Feb 23, 2024
Merged
@silverwind silverwind added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 23, 2024
@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 23, 2024
@silverwind
Copy link
Member

Merge #29191 before this and then alter this one to use the new shared functions.

denyskon
denyskon approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@denyskon denyskon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(assuming the deduplication after merging the other PR)

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged labels Feb 23, 2024
wxiaoguang
wxiaoguang approved these changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

@sahinakkaya sahinakkaya marked this pull request as draft February 24, 2024 09:51
@sahinakkaya sahinakkaya marked this pull request as ready for review February 24, 2024 09:57
@wxiaoguang wxiaoguang added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2024
@wxiaoguang wxiaoguang enabled auto-merge (squash) February 24, 2024 09:58
@wxiaoguang wxiaoguang merged commit d3982bc into go-gitea:main Feb 24, 2024
26 checks passed
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Feb 24, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 3, 2024
@lunny lunny added the type/changelog Adds the changelog for a new Gitea version label Mar 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@denyskon denyskon denyskon approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/changelog Adds the changelog for a new Gitea version
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
8 participants
@sahinakkaya @denyskon @delvh @silverwind @wxiaoguang @lunny @GiteaBot @6543