Fix fork repository cycle to self #2860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2860 +/- ##
=========================================
Coverage ? 26.85%
=========================================
Files ? 89
Lines ? 17607
Branches ? 0
=========================================
Hits ? 4728
Misses ? 12193
Partials ? 686Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
ethantkoenig
reviewed
Nov 5, 2017
routers/repo/pull.go
Outdated
| @@ -81,6 +80,31 @@ func getForkRepository(ctx *context.Context) *models.Repository { | |||
| orgs = append(orgs, org) | |||
| } | |||
| } | |||
|
|
|||
| var testForkRepo = forkRepo | |||
There was a problem hiding this comment.
nit: please use a more descriptive name than testForkRepo. Perhaps traverseParentRepo?
lunny
force-pushed
the
lunny/fix_fork_to_self
branch
from
35e4064
to
bf442d4
Compare
|
LGTM |
tboerger
added
lgtm/need 1
|
LGTM |
tboerger
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will fix #2858