Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use different directories for session files in integration tests #2834

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Use different directories for session files in integration tests #2834

merged 1 commit into from
Nov 3, 2017

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Nov 3, 2017

Could be one of reasons why mysql&pgsql integration tests fail randomly as both are run in parallel

@lafriks lafriks added this to the 1.3.0 milestone Nov 3, 2017
@codecov-io
Copy link

codecov-io commented Nov 3, 2017 •
edited
Loading

Codecov Report

Merging #2834 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2834   +/-   ##
=======================================
  Coverage   26.84%   26.84%           
=======================================
  Files          89       89           
  Lines       17608    17608           
=======================================
  Hits         4727     4727           
  Misses      12195    12195           
  Partials      686      686

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ee7248...6e03da0. Read the comment docs.

@tboerger tboerger added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 3, 2017
@Morlinest
Copy link
Member

LGTM

@tboerger tboerger added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 3, 2017
@lunny
Copy link
Member

lunny commented Nov 3, 2017

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 3, 2017
@lafriks lafriks merged commit 2e08f23 into go-gitea:master Nov 3, 2017
@lafriks lafriks deleted the fix/test_session_path branch November 3, 2017 00:48
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lafriks @codecov-io @Morlinest @lunny @tboerger