Use relative URLs for avatars on the dashboard #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2800 +/- ##
=======================================
Coverage 26.86% 26.86%
=======================================
Files 89 89
Lines 17596 17596
=======================================
Hits 4727 4727
Misses 12183 12183
Partials 686 686
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
jonasfranz
approved these changes
Oct 30, 2017
tonivj5
approved these changes
Oct 30, 2017
|
LGTM |
tboerger
added
lgtm/need 1
appleboy
approved these changes
Oct 31, 2017
|
LGTM |
tboerger
added
lgtm/done
|
make L-G-T-M work. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue with avatars that I've encountered on the home dashboard. The bug doesn't occur in 1.1.4 but it does in every release in the 1.2.x series. In the feed, the full URL for avatars (e.g.,
http://10.0.0.2:3000/avatars/29fbdca3e9ae935c9a5e12561bb4f086) is used. With this commit, now the URL will just be something like/avatars/eb6935a516d40bf3985ded3b01b1bcb7.