Improve profile for Organizations #27982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
github-actions
bot
added
the
modifies/templates
github-actions
bot
removed
the
modifies/templates
6543
reviewed
Nov 10, 2023
GiteaBot
added
lgtm/need 1
|
Semi-related: Regarding autofocus on search boxes, I would prefer to get rid of all of them eventually. There are certain unintended behaviours like IOS Safari zooming the page when a input element with font size less than 16px is focused. |
silverwind
reviewed
Nov 10, 2023
6543
reviewed
Nov 11, 2023
I also think it is better to get rid of all of them eventually. Some places have no autofocus and some places have. |
yp05327
force-pushed
the
improve-profile-in-org
branch
from
fc841f2 to
8ffefc9
Compare
Yeah, let's do in another PR. |
silverwind
reviewed
Nov 13, 2023
Co-authored-by: silverwind <me@silverwind.io>
silverwind
approved these changes
Nov 13, 2023
GiteaBot
added
lgtm/done
6543
approved these changes
Nov 13, 2023
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 14, 2023
* upstream/main: fixed duplicate attachments on dump on windows (go-gitea#28019) [skip ci] Updated translations via Crowdin packages: Calculate package size quota using package creator ID instead of owner ID (go-gitea#28007) Dont leak private users via extensions (go-gitea#28023) Improve profile for Organizations (go-gitea#27982) Enable system users search via the API (go-gitea#28013) Enable system users for comment.LoadPoster (go-gitea#28014) Change default size of issue/pr attachments and repo file (go-gitea#27946) Fix missing mail reply address (go-gitea#27997)
lunny
pushed a commit
that referenced
this pull request
Nov 20, 2023
Mentioned here: #27982 (comment)
silverwind
pushed a commit
to silverwind/gitea
that referenced
this pull request
Nov 21, 2023
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Fixes some problems in go-gitea#27955: - autofocus of the search box before: if access the home page will jump to the search box  after: will not jump to the search box  - incorrect display of overview tab before:  after:  - improve the permission check to the private profile repo In go-gitea#26295, we simply added access control to the private profile. But if user have access to the private profile repo , we should also display the profile. - add a button which can jump to the repo list? I agree @wxiaoguang 's opinion here: go-gitea#27955 (comment) But it seems that this feature is sponsored. So can we add a button which can quickly jump to the repo list or just move profile to the `overview` page? --------- Co-authored-by: silverwind <me@silverwind.io>
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some problems in #27955:
autofocus of the search box
before:
if access the home page will jump to the search box
after:
will not jump to the search box
incorrect display of overview tab
before:
after:
improve the permission check to the private profile repo
In Do not show Profile README when repository is private #26295, we simply added access control to the private profile.
But if user have access to the private profile repo , we should also display the profile.
add a button which can jump to the repo list?
I agree @wxiaoguang 's opinion here: Add Profile Readme for Organisations #27955 (comment)
But it seems that this feature is sponsored.
So can we add a button which can quickly jump to the repo list or just move profile to the
overviewpage?