-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show Sendmail settings on admin config page #2782
Conversation
6b6c1c8
to
10f9b54
Compare
Codecov Report
@@ Coverage Diff @@
## master #2782 +/- ##
=======================================
Coverage 27.18% 27.18%
=======================================
Files 88 88
Lines 17367 17367
=======================================
Hits 4721 4721
Misses 11961 11961
Partials 685 685 Continue to review full report at Codecov.
|
templates/admin/config.tmpl
Outdated
<dd>{{.Mailer.Host}}</dd> | ||
{{else}} | ||
<dt>{{.i18n.Tr "admin.config.mailer_use_sendmail"}}</dt> | ||
<dd><i class="fa fa{{if .Mailer.UseSendmail}}-check{{end}}-square-o"></i></dd> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The if .Mailer.UseSendmail at this line could be removed since we check it ar L173.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Just a |
LGTM |
Make LG-TM work |
* Show Sendmail settings on admin config page * Remove unecessary if statement
As title add the Sendmail setting to the config page