refactor postgres connection string building #27723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
URLs are notoriously difficult to work with, as the correct definition is so broad as to be functionally useless, having unescaped special characters can pose a security risk, or parsing issues. Use the net.URL type to ensure everything is escaped as required. This also fixes the existing unit tests which were invalid URLs and likely wrong in the first place, due to them combining query and database name.
The existing solution is rather inelegant and does not use a stdlib function that does basically the same thing. The test has been adapted to allow for unbracketed IPv6 addresses, as these are added by net.JoinHostPort.
lunny
added
the
type/refactoring
lunny
approved these changes
Oct 30, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Nov 1, 2023
wxiaoguang
added
backport/v1.21
wxiaoguang
approved these changes
Nov 1, 2023
GiteaBot
added
lgtm/done
wxiaoguang
added
the
reviewed/wait-merge
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Nov 1, 2023
This patchset changes the connection string builder to use net.URL and the host/port parser to use the stdlib function for splitting host from port. It also adds a footnote about a potentially required portnumber for postgres UNIX sockets. Fixes: go-gitea#24552
GiteaBot
added
backport/done
silverwind
pushed a commit
that referenced
this pull request
Nov 1, 2023
Backport #27723 by @mpldr This patchset changes the connection string builder to use net.URL and the host/port parser to use the stdlib function for splitting host from port. It also adds a footnote about a potentially required portnumber for postgres UNIX sockets. Fixes: #24552 Co-authored-by: Moritz Poldrack <33086936+mpldr@users.noreply.github.com>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Nov 2, 2023
* giteaofficial/main: Filter inactive auth sources (go-gitea#27870) refactor postgres connection string building (go-gitea#27723) doc: actions/act-runner: document running as a systemd service (go-gitea#27844) Support storage base path as prefix (go-gitea#27827)
This was referenced Jan 6, 2024
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Jan 6, 2024
lunny
pushed a commit
that referenced
this pull request
Jan 6, 2024
wxiaoguang
added a commit
that referenced
this pull request
Jan 6, 2024
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
This patchset changes the connection string builder to use net.URL and the host/port parser to use the stdlib function for splitting host from port. It also adds a footnote about a potentially required portnumber for postgres UNIX sockets. Fixes: go-gitea#24552
fuxiaohei
pushed a commit
to fuxiaohei/gitea
that referenced
this pull request
Jan 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset changes the connection string builder to use net.URL and the host/port parser to use the stdlib function for splitting host from port. It also adds a footnote about a potentially required portnumber for postgres UNIX sockets.
Fixes: #24552