Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn banner into a link to the github page #275

Merged
merged 1 commit into from
Nov 29, 2016

Conversation

strk
Copy link
Member

@strk strk commented Nov 27, 2016

Makes it easier to get to the official repo from old Gogs forks..

@Bwko
Copy link
Member

Bwko commented Nov 27, 2016

Rebase then lgtm

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 27, 2016
@tboerger
Copy link
Member

I can't see where this should be useful

@Bwko
Copy link
Member

Bwko commented Nov 28, 2016

@tboerger It's only useful when someone forks gitea and someone clicks on the header image.

@tboerger
Copy link
Member

But even than I don't see why it's useful. The fork will be anyway already displayed on the page

@bkcsoft
Copy link
Member

bkcsoft commented Nov 28, 2016

I'd just change it to ![](public/img/gitea-large-resize.png) instead (since otherwise it breaks when you're offline...)

@Bwko
Copy link
Member

Bwko commented Nov 28, 2016

@tboerger You're right, then we'll use @bkcsoft solution

@strk
Copy link
Member Author

strk commented Nov 28, 2016

Here's where it's useful:
https://github.com/strk/gogs/

@strk
Copy link
Member Author

strk commented Nov 28, 2016

Try to get from there to gitea (which is clearly the upstream, judging from the logo)

@tboerger
Copy link
Member

You have not forked from gitea, you have forked from Gogs

@strk
Copy link
Member Author

strk commented Nov 29, 2016

Exactly, long ago. Now in order not to waste time with dropping the fork, recreating it from gitea and then re-pushing all feature branches and re-open the then broken PRs to gitea and gogs... I think it would be much easier to just have a Gitea banner be a link to a Gitea website. Can be gitea.io if you don't like the github link

@tboerger tboerger added this to the 1.0.0 milestone Nov 29, 2016
@tboerger tboerger added the type/docs This PR mainly updates/creates documentation label Nov 29, 2016
@tboerger
Copy link
Member

tboerger commented Nov 29, 2016

Please replace the link to the image with public/img/gitea-large-resize.png

@strk
Copy link
Member Author

strk commented Nov 29, 2016 via email

@tboerger
Copy link
Member

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 29, 2016
@Bwko
Copy link
Member

Bwko commented Nov 29, 2016

LGTM

@tboerger tboerger merged commit ccad2cc into go-gitea:master Nov 29, 2016
@strk strk deleted the readmelink branch November 30, 2016 09:47
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants