Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating docmantation for fix #24552 #27444

Closed
wants to merge 3 commits into from

Conversation

gaurangkudale
Copy link

@gaurangkudale gaurangkudale commented Oct 4, 2023

Updating documentation for issue #24552
Please review and let me know if there are any suggestions (if everything goes well please mention it under hactober-accepted)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 4, 2023
@github-actions github-actions bot added the type/docs This PR mainly updates/creates documentation label Oct 4, 2023
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 4, 2023
@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2023
@@ -49,7 +49,7 @@ RUN pip3 install jupyter docutils

## `app.ini` file configuration

add one `[markup.XXXXX]` section per external renderer on your custom `app.ini`:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well… According to the example in https://docs.gitea.com/administration/config-cheat-sheet#markup-markup and my personal experience, I'd say your suggested fix is wrong.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for letting me know
So where should I change exactly?

@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/docs This PR mainly updates/creates documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants