Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When comparing with an non-exist repository, return 404 but 500 #27437

Merged
merged 2 commits into from
Oct 4, 2023
Merged

When comparing with an non-exist repository, return 404 but 500 #27437

merged 2 commits into from
Oct 4, 2023

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 4, 2023

No description provided.

@lunny lunny added type/bug backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 labels Oct 4, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 4, 2023
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 4, 2023
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 4, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 4, 2023
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 4, 2023
@lunny lunny enabled auto-merge (squash) October 4, 2023 13:27
@lunny lunny merged commit fe68bbe into go-gitea:main Oct 4, 2023
25 checks passed
@GiteaBot GiteaBot added this to the 1.22.0 milestone Oct 4, 2023
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 4, 2023
@lunny @GiteaBot
When comparing with an non-exist repository, return 404 but 500 (go-g…
4271c7e 
…itea#27437)
@GiteaBot GiteaBot mentioned this pull request Oct 4, 2023
Merged
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Oct 4, 2023
@GiteaBot GiteaBot mentioned this pull request Oct 4, 2023
Merged
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Oct 4, 2023
@lunny @GiteaBot
When comparing with an non-exist repository, return 404 but 500 (go-g…
94a1524 
…itea#27437)
@lunny lunny deleted the lunny/fix_compare_bug branch October 4, 2023 14:02
lunny added a commit that referenced this pull request Oct 4, 2023
@GiteaBot @lunny
When comparing with an non-exist repository, return 404 but 500 (#27437…
973b7f6 
…) (#27441)

Backport #27437 by @lunny

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
lunny added a commit that referenced this pull request Oct 4, 2023
@GiteaBot @lunny
When comparing with an non-exist repository, return 404 but 500 (#27437…
a9d547f 
…) (#27442)

Backport #27437 by @lunny

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
silverwind added a commit to silverwind/gitea that referenced this pull request Oct 4, 2023
@silverwind
Merge main, rename to gitea-auto
454e475 
* origin/main:
  When comparing with an non-exist repository, return 404 but 500 (go-gitea#27437)
  Fix pr template (go-gitea#27436)
  Use minimal required version on CI and remove unnecessary services (go-gitea#27429)
  Fix  missing `ctx`  in new_form.tmpl  (go-gitea#27434)
  Use flex-container for repo and org settings (go-gitea#27418)
  Fix yet another `ctx` template bug (go-gitea#27417)
  Add Index to `action.user_id` (go-gitea#27403)
  [skip ci] Updated translations via Crowdin
@GiteaBot
Copy link
Contributor

GiteaBot commented Oct 5, 2023

I was unable to create a backport for 1.20. @lunny, please send one manually. 🍵

go run ./contrib/backport 27437
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added the backport/manual No power to the bots! Create your backport yourself! label Oct 5, 2023
@GiteaBot
Copy link
Contributor

GiteaBot commented Oct 5, 2023

I was unable to create a backport for 1.21. @lunny, please send one manually. 🍵

go run ./contrib/backport 27437
...  // fix git conflicts if any
go run ./contrib/backport --continue

@lunny lunny added the backport/done All backports for this PR have been created label Oct 5, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jan 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wolfogre wolfogre wolfogre approved these changes

@CaiCandong CaiCandong CaiCandong approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.20 This PR should be backported to Gitea 1.20 backport/v1.21 This PR should be backported to Gitea 1.21 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @GiteaBot @wolfogre @CaiCandong